-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert to V2 Addon #144
Closed
NullVoxPopuli
wants to merge
16
commits into
GavinJoyce:move-tests-to-own-app
from
NullVoxPopuli:v2-addon-nvp
Closed
Convert to V2 Addon #144
NullVoxPopuli
wants to merge
16
commits into
GavinJoyce:move-tests-to-own-app
from
NullVoxPopuli:v2-addon-nvp
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
This was referenced May 29, 2022
Merged
Merged
Merged
Merged
NullVoxPopuli
force-pushed
the
v2-addon-nvp
branch
from
June 13, 2022 00:35
db68b71
to
caa7c4a
Compare
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already require ember-auto-import@v2 so when this PR is complete, it'll be a non-breaking change.
How we got here (in order)
How do you review something like this? (It's still a big PR)
Points of interest:
Things to keep in mind