Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to V2 Addon #144

Conversation

NullVoxPopuli
Copy link
Collaborator

@NullVoxPopuli NullVoxPopuli commented May 7, 2022

We already require ember-auto-import@v2 so when this PR is complete, it'll be a non-breaking change.

How we got here (in order)

  1. Move ember-modifier to dependencies #127
  2. Remove @tailwindcss/ui #147
  3. Switch to pnpm #148
  4. Convert to monorepo #152
  5. Move tests to own app #157
  6. and now this PR! (Convert to V2 Addon #144)

How do you review something like this? (It's still a big PR)
Points of interest:

  • the ci workflow is now generated from the root ci.yml, using: https://github.com/NullVoxPopuli/ember-ci-update
  • the rollup.config presently makes all files publicEntrypoints. We'll likely want to shift to gjs/gts and private component/modifier imports to reduce those publicEntrypoints -- because there is def stuff we don't want to be public API as most of this addon is to support the publicEntrypoints

Things to keep in mind

  • v2 addons + monorepos simulate real npm package + app consumption as close as possible
  • we don't have any sort of deploy preview set up or anything, so you may want to see if the docs app boots up and looks fine
  • if all the status checks are green, we should be good to go

@NullVoxPopuli NullVoxPopuli changed the base branch from master to move-tests-to-own-app June 13, 2022 00:44
@NullVoxPopuli NullVoxPopuli deleted the branch GavinJoyce:move-tests-to-own-app June 14, 2022 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant