Remove @tailwindcss/ui #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
NullVoxPopuli
force-pushed
the
remove-tailwind-ui
branch
from
934c0fc
to
e5ec7dc
Compare
|
Was the dependency inert or will it cause some effect for consumers of |
it was only used for the docs site -- after the 3 PRs I have up are merged -- I'm going to split this to a monorepo -- so it's easier to see what is docs, what is tests, and what is the actual addon |
|
The only thing that seemed to use the plugin was this list here which now doesn't look so good -- so I'll improve that a bit |
|
actually, I'm going to leave that out. I found the typography plugin is maintained, and is the spiritual successor for what we want. |
|
And here is that PR: #151 |
GavinJoyce
approved these changes
May 30, 2022
NullVoxPopuli
added
the
internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm splitting certain things out of the v2 addon conversion, because -- it's revealed a lot of bonkers behaviors we've been relying on.
Mainly,
@tailwindcss/uiis not a valid package, in that, it has a peerDepeendency on tailwindcss@v1, which we aren't using -- so withpnpm(coming in yet another PR), we have strict peer dependencies -- which means package authors need to communicate correctly 😅I think the best course of action here is to just remove
@tailwindcss/uias it also appears unmaintained -- last publish was 2 years ago.