Move tests to own app #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
force-pushed
the
move-tests-to-own-app
branch
from
85ec8e4
to
4179486
Compare
…ate the default rules for the current version of template lint
…real modules in development (3.27)
NullVoxPopuli
force-pushed
the
move-tests-to-own-app
branch
from
71ef163
to
1215681
Compare
NullVoxPopuli
added
the
internal
NullVoxPopuli
requested review from
alexlafroscia,
achambers and
GavinJoyce
and removed request for
alexlafroscia and
achambers
Closed
GavinJoyce
approved these changes
Jun 14, 2022
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in addition to moving tests:
I'm splitting certain things out of the #144, because it's very big, and since we all are part-time maintainers of this library, I'm trying to make the individual parts more easily reviewable.
Some advantages of monorepo (as it relates to addon development)
This allows for more confidence in dependency changes.
For ease of reviewing, this only moving the tests and dependencies out of the addon and into their own app. -- docs will be extracted in a separate PR