Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename jbrowse cli add-track --type to --trackType #1565

Merged
merged 2 commits into from
Dec 17, 2020
Merged

Conversation

cmdcolin
Copy link
Collaborator

Renames the current --type option to --trackType

In reference to
#1545

We could also consider adding an adapterType that overrides guessAdapterType, but that is currently difficult because every data adapter is kind of different (there is no standard based on supplying just urlTemplate...)

@cmdcolin cmdcolin changed the title Tracktype option Rename jbrowse cli add-track --type to --trackType Dec 15, 2020
@codecov
Copy link

codecov bot commented Dec 15, 2020

Codecov Report

Merging #1565 (f783144) into master (fc19bb3) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1565      +/-   ##
==========================================
+ Coverage   59.50%   59.51%   +0.01%     
==========================================
  Files         435      435              
  Lines       19561    19561              
  Branches     4564     4564              
==========================================
+ Hits        11640    11642       +2     
+ Misses       7627     7625       -2     
  Partials      294      294              
Impacted Files Coverage Δ
products/jbrowse-cli/src/commands/add-track.ts 46.22% <100.00%> (ø)
...inearGenomeView/components/RefNameAutocomplete.tsx 89.65% <0.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc19bb3...f783144. Read the comment docs.

@rbuels
Copy link
Contributor

rbuels commented Dec 17, 2020

this is a breaking change, but it's probably early enough that we can slip it in without too much worry

@rbuels rbuels merged commit 2de8847 into master Dec 17, 2020
@rbuels rbuels deleted the tracktype_option branch December 17, 2020 21:30
@cmdcolin cmdcolin added the enhancement New feature or request label Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants