Fix small dev warning about stale update after unmount if about dialo…

…g closed
GMOD · Dec 15, 2020 · fc19bb3 · fc19bb3
1 parent d8ca43a
commit fc19bb3
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/plugins/linear-genome-view/src/LinearGenomeView/components/AboutDialog.tsx b/plugins/linear-genome-view/src/LinearGenomeView/components/AboutDialog.tsx
@@ -253,21 +253,27 @@ export default function AboutDialog({
   useEffect(() => {
     const aborter = new AbortController()
     const { signal } = aborter
+    let cancelled = false
     ;(async () => {
       try {
         const adapterConfig = getConf(model, 'adapter')
         const result = await rpcManager.call(sessionId, 'CoreGetInfo', {
           adapterConfig,
           signal,
         })
-        setInfo(result as FileInfo)
+        if (!cancelled) {
+          setInfo(result as FileInfo)
+        }
       } catch (e) {
-        setError(e)
+        if (!cancelled) {
+          setError(e)
+        }
       }
     })()
 
     return () => {
       aborter.abort()
+      cancelled = true
     }
   }, [model, rpcManager, sessionId])