Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite Track.get_metadata #22

Closed
2 of 4 tasks
github-actions bot opened this issue Sep 1, 2020 · 2 comments · Fixed by #57
Closed
2 of 4 tasks

Rewrite Track.get_metadata #22

github-actions bot opened this issue Sep 1, 2020 · 2 comments · Fixed by #57

Comments

@github-actions
Copy link

github-actions bot commented Sep 1, 2020 •
edited by FUMR-bot
Loading

  • lyrics
  • rewrite title parsing
  • replayGain
  • multiple artists

This issue has been automatically created by todo-actions based on a TODO comment found in tidal_async/api.py:182. It will automatically be closed when the TODO comment is removed from master.
github-actions bot pushed a commit that referenced this issue Sep 1, 2020
@todo-actions
Update TODO references: #18, #19, #20, #21, #22, #23, #24, #25, #26
d660aee
@wvffle
Copy link
Contributor

wvffle commented Sep 1, 2020

What exacly is broken here?

@JuniorJPDJ
Copy link
Contributor

I'm not sure if anything is broken, but also not sure if it works as intended - it wasn't really tested at all.
We need to get rid of @divadsn's function from #24 because it's unreadable and probably add some other tags.
Check if all tags are present in track etc
Maybe "rewrite" would be better name of issue/TODO item.

@FUMR-bot FUMR-bot changed the title fix Track.get_metadata Rewrite Track.get_metadata Sep 14, 2020
JuniorJPDJ added a commit that referenced this issue May 14, 2021
@JuniorJPDJ
feat(Track.get_metadata): add lyrics tag support
aac5c7f 
also adds prelimitary support for subtitles tag
to add better support for subtitles tagging beetbox/mediafile#48 will need to be resolved

finishes metadata function and resolves #22
@JuniorJPDJ JuniorJPDJ linked a pull request May 14, 2021 that will close this issue
Lyrics/subtitles, better metadata and other fixes #57
Merged
JuniorJPDJ added a commit that referenced this issue May 15, 2021
@JuniorJPDJ
feat(Track.get_metadata): add lyrics tag support
9f1ba11 
also adds prelimitary support for subtitles tag
to add better support for subtitles tagging beetbox/mediafile#48 will need to be resolved

finishes metadata function and resolves #22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Lyrics/subtitles, better metadata and other fixes FUMR/tidal-async
2 participants
@JuniorJPDJ @wvffle