New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lyrics/subtitles, better metadata and other fixes #57

Merged

JuniorJPDJ merged 8 commits into master from JuniorJPDJ/idkwtf

May 15, 2021

Contributor

JuniorJPDJ commented May 14, 2021

Hmmm.

JuniorJPDJ added 5 commits

May 14, 2021 03:40


          ci: temporarily disable darglint

7185e57

We first need docs to have test for them ;/


          fix(utils.Cachable): fix lock releasing and rename Cachable to AsyncC…

3055e7a

…achable

lock wasn't released sometimes and random cached operations were freezing
I'm not sure why, but now it works!


          feat(ArtistType): add ArtistType enum

802145e

resolves #49
resolves #50


          feat(Track): update get_metadata to provide mediafile compatible dict

also updates gen_title and gen_artists to better format

depends on beetbox/mediafile#42


          ci: fix tests

cdd7492

JuniorJPDJ linked an issue

that may be closed by this pull request

Artist types enum #49

Closed

JuniorJPDJ marked this pull request as ready for review

May 14, 2021 02:08

JuniorJPDJ requested review from wvffle, divadsn, encryptize, loboda4450 and Mrkazik99

May 14, 2021 15:06


          feat(Track): add lyrics and subtitles downloading support

07e91df

also adds simple tests
resolves #3

JuniorJPDJ linked an issue

that may be closed by this pull request

Downloading lyrics #3

Closed

JuniorJPDJ changed the title ~~Lots of fixes and better metadata~~ Lyrics/subtitles, better metadata and other fixes


          feat(Track.get_metadata): add lyrics tag support

aac5c7f

also adds prelimitary support for subtitles tag
to add better support for subtitles tagging beetbox/mediafile#48 will need to be resolved

finishes metadata function and resolves #22

JuniorJPDJ linked an issue

that may be closed by this pull request

Rewrite Track.get_metadata #22

Closed

4 tasks

JuniorJPDJ mentioned this pull request

Docs docs docs #59

Merged

Contributor Author

JuniorJPDJ commented May 15, 2021

darglint is enabled back in #59

Contributor Author

JuniorJPDJ commented May 15, 2021

Can someone gimme review here? I'd like to merge this :V

wvffle reviewed

View reviewed changes

tidal_async/api.py Show resolved Hide resolved

wvffle requested changes

View reviewed changes

tidal_async/utils.py Show resolved Hide resolved

tidal_async/utils.py Show resolved Hide resolved


          perf(Track.get_metadata): get all data at same time

11624d4

JuniorJPDJ requested a review from wvffle

May 15, 2021 13:44

wvffle approved these changes

View reviewed changes

JuniorJPDJ merged commit 5afccba into master

JuniorJPDJ deleted the JuniorJPDJ/idkwtf branch

May 15, 2021 13:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

wvffle wvffle approved these changes

divadsn Awaiting requested review from divadsn

encryptize Awaiting requested review from encryptize

loboda4450 Awaiting requested review from loboda4450

Mrkazik99 Awaiting requested review from Mrkazik99

Labels

None yet