Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make filelike extra depend on music-service-async-interface['filelike'], not directly on http-seekable-file['async'] #18

Open
github-actions bot opened this issue Sep 1, 2020 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@github-actions
Copy link

github-actions bot commented Sep 1, 2020


This issue has been automatically created by todo-actions based on a TODO comment found in pyproject.toml:22. It will automatically be closed when the TODO comment is removed from master.

@JuniorJPDJ
Copy link
Contributor

I don't know how to do this.
If someone has solution in his mind or want to look for it - please do

@JuniorJPDJ JuniorJPDJ added the help wanted Extra attention is needed label Sep 3, 2020
@JuniorJPDJ
Copy link
Contributor

I tried doing:

"music-service-async-interface['filelike']" = { git = "https://github.com/FUMR/music-service-async-interface.git", rev = "a81d3dd8a56ef7198a752e4ffb83ee57e9835aa5", extras = ["filelike"], optional = true }

in pyproject.toml but it didn't work:

Installing dependencies from lock file
Warning: The lock file is not up to date with the latest changes in pyproject.toml. You may be getting outdated dependencies. Run update to update them.

  RuntimeError

  The dependency name for music-service-async-interface['filelike'] does not match the actual package's name: music-service-async-interface

  at /usr/lib/python3.9/site-packages/poetry/puzzle/provider.py:291 in get_package_from_directory
      287│         )
      288│ 
      289│         if name and name != package.name:
      290│             # For now, the dependency's name must match the actual package's name
    → 291│             raise RuntimeError(
      292│                 "The dependency name for {} does not match the actual package's name: {}".format(
      293│                     name, package.name
      294│                 )
      295│             )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant