Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "upgrade react-native-live-markdown to 0.1.76" #42843

Merged
merged 1 commit into from
May 30, 2024
Merged

Revert "upgrade react-native-live-markdown to 0.1.76" #42843

merged 1 commit into from
May 30, 2024

Conversation

ishpaul777
Copy link
Contributor

Reverts #42454

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖 iOS 🍎
❌ FAILED ❌ ❌ FAILED ❌
The QR code can't be generated, because the android build failed The QR code can't be generated, because the iOS build failed
Desktop 💻 Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/42843/NewExpensify.dmg https://42843.pr-testing.expensify.com
Desktop Web

👀 View the workflow run that generated this build 👀

@ishpaul777 ishpaul777 marked this pull request as ready for review May 30, 2024 19:10
@ishpaul777 ishpaul777 requested a review from a team as a code owner May 30, 2024 19:10
@melvin-bot melvin-bot bot requested review from cristipaval and removed request for a team May 30, 2024 19:10
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented May 30, 2024

@cristipaval Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@ishpaul777
Copy link
Contributor Author

Revert solves #42766 @puneetlath

WhatsApp.Video.2024-05-31.at.12.51.18.AM.mp4

@puneetlath puneetlath merged commit 4df3c76 into Expensify:main May 30, 2024
15 of 17 checks passed
@melvin-bot melvin-bot bot added the Emergency label May 30, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented May 30, 2024

@puneetlath looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

OSBotify pushed a commit that referenced this pull request May 30, 2024
@puneetlath @OSBotify
Merge pull request #42843 from ishpaul777/revert-42454-update-rn-live…
db6a0d7 
…-markdown-0176

Revert "upgrade react-native-live-markdown to 0.1.76"

(cherry picked from commit 4df3c76)
@puneetlath
Copy link
Contributor

Straight revert to a deploy blocker, so merged without checklist.

@ishpaul777 ishpaul777 mentioned this pull request May 30, 2024
Merged
50 tasks
@github-actions github-actions bot mentioned this pull request May 30, 2024
Closed
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@kbecciv kbecciv mentioned this pull request May 30, 2024
Closed
6 tasks
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 1.4.77-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.77-11 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.77-11 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@VickyStash VickyStash mentioned this pull request May 31, 2024
Merged
53 tasks
@bernhardoj bernhardoj mentioned this pull request Jun 3, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puneetlath puneetlath puneetlath approved these changes

@cristipaval cristipaval Awaiting requested review from cristipaval

Assignees
No one assigned
Labels
Ready To Build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ishpaul777 @puneetlath @OSBotify