Emojis larger in other contexts than just single character messages #40692

kbieganowski · 2024-04-22T13:05:34Z

Details

Fixed Issues

$ #4114

PROPOSAL: n/a

Tests

Composer:

Draft a message (of any length) with only emojis
Add other plain text characters in a message in the composer

Verify that emojis appear very large (27px) in the composer (for emojis only input)
Verify that emojis are larger (19pt) compared to the default size for text (15px) in the composer (emojis + text input)

Report history:

Send a message with emojis only
Send a message with emojis and text

Verify that emojis appear very large (27px) in the report history (emojis only comment)
Verify that emojis are larger (19px) compared to the default size for text (15pt) in the chat history and vertically centered with respect to eachother, such that the baseline of the emoji is below the plain text and the middle of the text vertically aligns with the middle of the emoji like shown here

Settings:

Go to Settings -> Profile and add emoji to your last name

Verify that emoji appear larger (19pt) than the rest of the text (15pt) in the text input

Save the changes
Open LHP

Verify that emoji in user's last name appear larger (25px) compared to the rest of the text (22px)

Offline tests

n/a

QA Steps

Same as in Tests section

Note: If more details regarding tests flow are needed, they can be found in description of related issue

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

chrome_chat.mp4

MacOS: Desktop

desktop_chat.mp4

melvin-bot · 2024-04-23T13:44:53Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

roryabraham · 2024-04-23T16:50:44Z

src/libs/EmojiUtils.ts

+ */
+
+// Surrogate pairs (combined emojis)
+const highSurrogateStart = 0xd800;


Let's use SCREAMING_SNAKE_CASE for all these constants

sure! updated

roryabraham · 2024-04-23T16:51:07Z

src/libs/EmojiUtils.ts

+const variationModifierStart = 0xfe00; // Request text presentation of emoji
+const variationModifierEnd = 0xfe0f; // Indicate that the character should be displayed as an emoji
+
+const codePointFromSurrogatePair = (pair: string) => {


let's use the function keyword instead of arrow functions, just because it's the more common pattern in this codebase

MrRefactor · 2024-04-24T11:10:36Z

src/hooks/useMarkdownStyle.ts

 import FontUtils from '@styles/utils/FontUtils';
 import variables from '@styles/variables';
 import useTheme from './useTheme';

-function useMarkdownStyle(message: string | null = null): MarkdownStyle {
+function useMarkdownStyle(containsEmojisOnly?: boolean): MarkdownStyle {


please stay with containsOnlyEmojis or textContainsOnlyEmojis

fair point, changed to inputContainsOnlyEmojis

fabioh8010 · 2024-04-24T21:41:44Z

src/libs/EmojiUtils.ts

+    return 2; // Variations and non-BMP characters
+}
+
+function splitTextWithEmojis(text: string): string[] {


I think we could vastly simplify this code if we use a combination of regex + this logic @roryabraham designed in the past.

First, we need to update CONST.REGEX.EMOJIS to include the new d flag which I've implemented in the past for this issue and is available now on Hermes engine:

diff --git a/src/CONST.ts b/src/CONST.ts index f0139d82e6..ebe0ab7549 100755 --- a/src/CONST.ts +++ b/src/CONST.ts @@ -1760,8 +1760,8 @@ const CONST = { // eslint-disable-next-line max-len, no-misleading-character-class EMOJI: /[\p{Extended_Pictographic}\u200d\u{1f1e6}-\u{1f1ff}\u{1f3fb}-\u{1f3ff}\u{e0020}-\u{e007f}\u20E3\uFE0F]|[#*0-9]\uFE0F?\u20E3/gu, - // eslint-disable-next-line max-len, no-misleading-character-class - EMOJIS: /[\p{Extended_Pictographic}](\u200D[\p{Extended_Pictographic}]|[\u{1F3FB}-\u{1F3FF}]|[\u{E0020}-\u{E007F}]|\uFE0F|\u20E3)*|[\u{1F1E6}-\u{1F1FF}]{2}|[#*0-9]\uFE0F?\u20E3/gu, + // eslint-disable-next-line max-len, no-misleading-character-class, no-empty-character-class + EMOJIS: /[\p{Extended_Pictographic}](\u200D[\p{Extended_Pictographic}]|[\u{1F3FB}-\u{1F3FF}]|[\u{E0020}-\u{E007F}]|\uFE0F|\u20E3)*|[\u{1F1E6}-\u{1F1FF}]{2}|[#*0-9]\uFE0F?\u20E3/dgu, // eslint-disable-next-line max-len, no-misleading-character-class EMOJI_SKIN_TONES: /[\u{1f3fb}-\u{1f3ff}]/gu,

Then, let's implement the splitTextWithEmojis function which will use the regex and indices feature and is based on Rory's initial idea:

type TextWithEmoji = { text: string; isEmoji: boolean; }; function splitTextWithEmojis(text: string): TextWithEmoji[] { if (!text) { return []; } // The regex needs to be cloned because `exec()` is a stateful operation and maintains the state inside // the regex variable itself, so we must have a independent instance for each function's call. const emojisRegex = new RegExp(CONST.REGEX.EMOJIS, CONST.REGEX.EMOJIS.flags); const splitText: TextWithEmoji[] = []; let regexResult: RegExpExecArray | null; let lastMatchIndexEnd = 0; do { regexResult = emojisRegex.exec(text); if (regexResult?.indices) { const matchIndexStart = regexResult.indices[0][0]; const matchIndexEnd = regexResult.indices[0][1]; if (matchIndexStart > lastMatchIndexEnd) { splitText.push({ text: text.slice(lastMatchIndexEnd, matchIndexStart), isEmoji: false, }); } splitText.push({ text: text.slice(matchIndexStart, matchIndexEnd), isEmoji: true, }); lastMatchIndexEnd = matchIndexEnd; } } while (regexResult !== null); if (lastMatchIndexEnd < text.length) { splitText.push({ text: text.slice(lastMatchIndexEnd, text.length), isEmoji: false, }); } return splitText; }

You'll notice some TS errors in the function regarding indices not being existent. We'll need to add declarations for ES2022 RegExp in tsconfig.json file:

diff --git a/tsconfig.json b/tsconfig.json index 7f7b7479f4..ca3cdfa4fa 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -20,7 +20,8 @@ "es2022.object", "es2022.string", "ES2021.Intl", - "ES2023.Array" + "ES2023.Array", + "ES2022.RegExp" ], "allowJs": true, "checkJs": false,

Let's test this function now! If I pass this string Hello world 🙂🙂🙂 ! 😶‍🌫️😶‍🌫️😶‍🌫️ test 😶‍🌫️ 😶‍🌫️ test2 👍👍🏿 which has some normal and surrogate emojis, the output will be:

[ {"isEmoji":false,"text":"Hello world "}, {"isEmoji":true,"text":"🙂"}, {"isEmoji":true,"text":"🙂"}, {"isEmoji":true,"text":"🙂"}, {"isEmoji":false,"text":" ! "}, {"isEmoji":true,"text":"😶‍🌫️"}, {"isEmoji":true,"text":"😶‍🌫️"}, {"isEmoji":true,"text":"😶‍🌫️"}, {"isEmoji":false,"text":" test "}, {"isEmoji":true,"text":"😶‍🌫️"}, {"isEmoji":false,"text":" "}, {"isEmoji":true,"text":"😶‍🌫️"}, {"isEmoji":false,"text":" test2 "}, {"isEmoji":true,"text":"👍"}, {"isEmoji":true,"text":"👍🏿"} ]

You can adjust the function to just return an array withe the separated tokens if you want, could you give it a try and see if it suits your needs in the PR?

Update: we are still testing the regex solution

@kbieganowski I've updated my previous solution:

Fixed splitTextWithEmojis function to always create a separate regex instance on each call, thus preventing the issue we were discussing internally.

Simplified solution to the TS errors regarding indices.

@kbieganowski After internal discussions, we noticed that having the g (global) flag on CONST.REGEX.EMOJIS can result in hard-to-detect bugs throughout the App due to the stateful nature of the regex when it has the g flag. For example, repeatedly calls to test() with same input will sometimes return different results because the regex is being used globally.

So, I would suggest to remove the g flag from CONST.REGEX.EMOJIS:

// eslint-disable-next-line max-len, no-misleading-character-class, no-empty-character-class EMOJIS: /[\p{Extended_Pictographic}](\u200D[\p{Extended_Pictographic}]|[\u{1F3FB}-\u{1F3FF}]|[\u{E0020}-\u{E007F}]|\uFE0F|\u20E3)*|[\u{1F1E6}-\u{1F1FF}]{2}|[#*0-9]\uFE0F?\u20E3/du,

And then adding it when cloning the regex inside splitTextWithEmojis:

// We clone the regex and add the `g` (global) flag in order to `exec()` be stateful and work properly. // Adding the flag directly to CONST.ts can result in bugs throughout the App due to the stateful nature // of the regex when it has the `g` flag. const emojisRegex = new RegExp(CONST.REGEX.EMOJIS, CONST.REGEX.EMOJIS.flags.concat('g'));

This change will require testing in all areas of the app that uses CONST.REGEX.EMOJIS since we removed the g flag now.

I would advice doing the same for CONST.REGEX.EMOJI and CONST.REGEX.EMOJI_SKIN_TONES, that could be done in a follow-up PR to avoid regressions on this one.

kbieganowski · 2024-05-07T12:28:09Z

Hey @fabioh8010, I've validated other usages of the regex and everything seems to work as expected. Ready for a re-review

fabioh8010

Few comments, also please make sure all places where CONST.REGEX.EMOJIS is used (src/components/InlineCodeBlock/WrappedText.tsx, src/libs/EmojiUtils.ts, src/libs/ValidationUtils.ts) are properly handled after removing the g flag.

fabioh8010 · 2024-05-08T07:38:53Z

src/components/Composer/index.native.tsx

@@ -65,7 +67,7 @@ function Composer(
    }, [shouldClear, onClear]);

    const maxHeightStyle = useMemo(() => StyleUtils.getComposerMaxHeightStyle(maxLines, isComposerFullSize), [StyleUtils, isComposerFullSize, maxLines]);
-    const composerStyle = useMemo(() => StyleSheet.flatten(style), [style]);
+    const composerStyle = useMemo(() => StyleSheet.flatten([style, textContainsOnlyEmojis ? {lineHeight: 32} : null]), [style, textContainsOnlyEmojis]);


Suggested change

const composerStyle = useMemo(() => StyleSheet.flatten([style, textContainsOnlyEmojis ? {lineHeight: 32} : null]), [style, textContainsOnlyEmojis]);

const composerStyle = useMemo(() => StyleSheet.flatten([style, textContainsOnlyEmojis ? {lineHeight: variables.lineHeightXXXLarge} : null]), [style, textContainsOnlyEmojis]);

Maybe did you want to use lineHeightXXXLarge (or perhaps a different variable)?

I went with new variables rather than using existing ones because this styles are strictly related to composer/input and I didn't want potential changes to the UI in future to break composer or inputs as well but no more magic numbers

fabioh8010 · 2024-05-08T07:39:30Z

src/components/TextInput/BaseTextInput/index.tsx

@@ -380,6 +380,7 @@ function BaseTextInput(
                                    // Add disabled color theme when field is not editable.
                                    inputProps.disabled && styles.textInputDisabled,
                                    styles.pointerEventsAuto,
+                                    isMarkdownEnabled ? {lineHeight: 18} : null,


Suggested change

isMarkdownEnabled ? {lineHeight: 18} : null,

isMarkdownEnabled ? {lineHeight: variables.lineHeightLarge} : null,

makes sense (or perhaps a different variable)?

fabioh8010 · 2024-05-08T07:41:17Z

src/hooks/useMarkdownStyle.ts

@@ -21,7 +19,7 @@ function useMarkdownStyle(message: string | null = null): MarkdownStyle {
                fontSize: variables.fontSizeLarge,
            },
            emoji: {
-                fontSize: emojiFontSize,
+                fontSize: inputContainsOnlyEmojis ? 27 : 19,


Same, shouldn't we use already defined variables for those values, or create new ones if they are new?

fabioh8010 · 2024-05-08T07:44:35Z

src/pages/home/report/comment/TextWithEmojiFragment.tsx

+    isEdited?: boolean;
+    emojisOnly?: boolean;
+};
+function TextWithEmojiFragment({message, passedStyles, styleAsDeleted, styleAsMuted, isSmallScreenWidth, isEdited, emojisOnly}: ComponentProps) {


Suggested change

function TextWithEmojiFragment({message, passedStyles, styleAsDeleted, styleAsMuted, isSmallScreenWidth, isEdited, emojisOnly}: ComponentProps) {

function TextWithEmojiFragment({message, passedStyles, styleAsDeleted, styleAsMuted, isSmallScreenWidth, isEdited, emojisOnly}: ComponentProps) {

fabioh8010 · 2024-05-08T07:45:12Z

src/pages/home/report/comment/TextWithEmojiFragment.tsx

+import variables from '@styles/variables';
+import CONST from '@src/CONST';
+
+type ComponentProps = {


Suggested change

type ComponentProps = {

type TextWithEmojiFragmentProps = {

Also, please add descriptions for each prop

fabioh8010 · 2024-05-08T07:45:32Z

src/pages/home/report/comment/TextWithEmojiFragment.tsx

+
+type ComponentProps = {
+    message: string;
+    passedStyles: StyleProp<TextStyle>;


Suggested change

passedStyles: StyleProp<TextStyle>;

passedStyles?: StyleProp<TextStyle>;

Style props are optional by convention.

fabioh8010

Just one nitpick, amazing work! LGTM 🚀

fabioh8010 · 2024-05-09T10:12:04Z

src/pages/home/report/comment/TextWithEmojiFragment.tsx

+type TextWithEmojiFragmentProps = {
+    /** The message to be displayed */
+    message: string;
+    /** Additional styles to add after local styles. */
+    passedStyles?: StyleProp<TextStyle>;
+    /** Should this message fragment be styled as deleted? */
+    styleAsDeleted?: boolean;
+    /** Should this message fragment be styled as muted? */
+    styleAsMuted?: boolean;
+    /** Is message displayed on narrow screen? */
+    isSmallScreenWidth?: boolean;
+    /** Should "(edited)" suffix be rendered? */
+    isEdited?: boolean;
+    /** Does message contain only emojis? */
+    emojisOnly?: boolean;
+};


Suggested change

type TextWithEmojiFragmentProps = {

/** The message to be displayed */

message: string;

/** Additional styles to add after local styles. */

passedStyles?: StyleProp<TextStyle>;

/** Should this message fragment be styled as deleted? */

styleAsDeleted?: boolean;

/** Should this message fragment be styled as muted? */

styleAsMuted?: boolean;

/** Is message displayed on narrow screen? */

isSmallScreenWidth?: boolean;

/** Should "(edited)" suffix be rendered? */

isEdited?: boolean;

/** Does message contain only emojis? */

emojisOnly?: boolean;

};

type TextWithEmojiFragmentProps = {

/** The message to be displayed */

message: string;

/** Additional styles to add after local styles. */

passedStyles?: StyleProp<TextStyle>;

/** Should this message fragment be styled as deleted? */

styleAsDeleted?: boolean;

/** Should this message fragment be styled as muted? */

styleAsMuted?: boolean;

/** Is message displayed on narrow screen? */

isSmallScreenWidth?: boolean;

/** Should "(edited)" suffix be rendered? */

isEdited?: boolean;

/** Does message contain only emojis? */

emojisOnly?: boolean;

};

Add spaces between the props

melvin-bot · 2024-05-16T13:16:44Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

# Conflicts: # src/pages/home/report/comment/TextCommentFragment.tsx # src/styles/index.ts

VickyStash · 2024-07-26T10:57:37Z

@roryabraham I've applied your suggestions, please take another look

src/pages/home/report/ReportActionItemMessageHeaderSender.tsx

OSBotify · 2024-07-27T04:24:29Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

parasharrajat · 2024-07-27T06:32:55Z

@VickyStash How are we going to handle follow-up fixes? #40692 (comment)

VickyStash · 2024-07-29T07:19:50Z

@VickyStash How are we going to handle follow-up fixes? #40692 (comment)

@parasharrajat I can open the issues for the @expensify/react-native-live-markdown related problems.
As for the app-related one I'm going to investigate it today
What do you think?

VickyStash · 2024-07-29T08:59:19Z

@parasharrajat The follow-up PR for the app is ready, please take a look

parasharrajat · 2024-07-29T09:19:35Z

Sound awesome. Please tag me to the new issues.

VickyStash · 2024-07-29T14:35:58Z

@parasharrajat I've created two issues in @expensify/react-native-live-markdown lib:

Expensify/react-native-live-markdown#443
Expensify/react-native-live-markdown#444

I have some doubts about the input dancing bug cause today, during re-testing, I had an idea of how it could be fixed by updating styles on the app side. If it works, I'll open one more follow-up

OSBotify · 2024-07-29T19:30:01Z

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.0.14-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-07-31T19:39:56Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.0.14-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

kbieganowski force-pushed the feat/enlarge-emojis-font-size branch from a121cc6 to 40e2f83 Compare April 22, 2024 13:07

kbieganowski mentioned this pull request Apr 22, 2024

Enlarge emojis within text #37980

Closed

50 tasks

kbieganowski force-pushed the feat/enlarge-emojis-font-size branch from bdc28a6 to 09116ba Compare April 23, 2024 13:03

kbieganowski mentioned this pull request Apr 23, 2024

[$1000] Make emojis larger in other contexts than just single character messages #4114

Open

roryabraham reviewed Apr 23, 2024

View reviewed changes

MrRefactor approved these changes Apr 24, 2024

View reviewed changes

fabioh8010 reviewed Apr 24, 2024

View reviewed changes

kbieganowski force-pushed the feat/enlarge-emojis-font-size branch 2 times, most recently from bd26c68 to 797cfeb Compare April 26, 2024 11:38

kbieganowski force-pushed the feat/enlarge-emojis-font-size branch from 5cec5d3 to 1508719 Compare May 6, 2024 11:26

kbieganowski requested a review from fabioh8010 May 7, 2024 12:28

fabioh8010 reviewed May 8, 2024

View reviewed changes

kbieganowski requested a review from fabioh8010 May 9, 2024 07:49

fabioh8010 approved these changes May 9, 2024

View reviewed changes

kbieganowski added 6 commits May 16, 2024 13:56

rebase wip

2fcb0c4

wip: updated emojis size in settings input and LHP username

7dcb710

wip: emojis font size - CR changes

1ded82a

rebase wip

ee38c51

rebase wip

0208efe

CR fixes

d10aeb2

kbieganowski force-pushed the feat/enlarge-emojis-font-size branch from 9b4a01a to d10aeb2 Compare May 16, 2024 13:15

kbieganowski marked this pull request as ready for review May 16, 2024 13:16

kbieganowski requested review from a team as code owners May 16, 2024 13:16

melvin-bot bot requested review from parasharrajat and removed request for a team May 16, 2024 13:16

VickyStash added 4 commits July 26, 2024 12:15

Rename boolean variable

959fac5

Minor improvement

a5dc739

Merge branch 'refs/heads/main' into feat/enlarge-emojis-font-size

ce32c11

# Conflicts: # src/pages/home/report/comment/TextCommentFragment.tsx # src/styles/index.ts

Minor update after merging main

46a71dd

parasharrajat reviewed Jul 26, 2024

View reviewed changes

src/pages/home/report/ReportActionItemMessageHeaderSender.tsx Show resolved Hide resolved

Add ReportActionItemMessageHeaderSender display name

08e72ff

parasharrajat approved these changes Jul 26, 2024

View reviewed changes

melvin-bot bot requested a review from roryabraham July 26, 2024 20:39

roryabraham approved these changes Jul 27, 2024

View reviewed changes

roryabraham merged commit 5e65276 into Expensify:main Jul 27, 2024
16 checks passed

VickyStash mentioned this pull request Jul 29, 2024

Increase emoji size within text messages on web #46398

Closed

50 tasks

github-actions bot mentioned this pull request Jul 29, 2024

Deploy Checklist: New Expensify 2024-07-29 #46436

Closed

84 tasks

This was referenced Jul 29, 2024

[$250] iOS - Composer - "Write something..." is not in the middle of the composer #46443

Closed

Revert "Emojis larger in other contexts than just single character messages" #46446

Closed

francoisl mentioned this pull request Jul 29, 2024

[$250] iOS - Composer - Emoji is cut off when entering one letter after the emoji #46444

Closed

6 tasks

marcochavezf mentioned this pull request Jul 29, 2024

Revert "Emojis larger in other contexts than just single character messages" #46463

Merged

This was referenced Jul 30, 2024

[$250] Emoji - highlighting Emoji is not retangular #46453

Closed

Fix emojis display #46478

Closed

Julesssss mentioned this pull request Jul 30, 2024

[HOLD for payment 2024-08-09] Room - System message shows code when adding emoji and mark down to room description #46486

Closed

6 tasks

gijoe0295 mentioned this pull request Jul 30, 2024

Chat - Different placement of sender name and message on staging vs production #46489

Closed

6 tasks

VickyStash mentioned this pull request Aug 16, 2024

Enlarge emojis in other contexts than just single character messages #47547

Open

50 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Emojis larger in other contexts than just single character messages #40692

Emojis larger in other contexts than just single character messages #40692

kbieganowski commented Apr 22, 2024 •

edited

Loading

melvin-bot bot commented Apr 23, 2024

roryabraham Apr 23, 2024

kbieganowski Apr 24, 2024

roryabraham Apr 23, 2024

MrRefactor Apr 24, 2024

kbieganowski Apr 24, 2024

fabioh8010 Apr 24, 2024 •

edited

Loading

fabioh8010 Apr 25, 2024

fabioh8010 Apr 25, 2024

fabioh8010 Apr 26, 2024 •

edited

Loading

kbieganowski commented May 7, 2024

fabioh8010 left a comment

fabioh8010 May 8, 2024

kbieganowski May 9, 2024

fabioh8010 May 8, 2024

fabioh8010 May 8, 2024

fabioh8010 May 8, 2024

fabioh8010 May 8, 2024

fabioh8010 May 8, 2024

fabioh8010 left a comment

fabioh8010 May 9, 2024

melvin-bot bot commented May 16, 2024

VickyStash commented Jul 26, 2024

OSBotify commented Jul 27, 2024

parasharrajat commented Jul 27, 2024

VickyStash commented Jul 29, 2024

VickyStash commented Jul 29, 2024

parasharrajat commented Jul 29, 2024

VickyStash commented Jul 29, 2024

OSBotify commented Jul 29, 2024

OSBotify commented Jul 31, 2024

	const composerStyle = useMemo(() => StyleSheet.flatten([style, textContainsOnlyEmojis ? {lineHeight: 32} : null]), [style, textContainsOnlyEmojis]);
	const composerStyle = useMemo(() => StyleSheet.flatten([style, textContainsOnlyEmojis ? {lineHeight: variables.lineHeightXXXLarge} : null]), [style, textContainsOnlyEmojis]);

	isMarkdownEnabled ? {lineHeight: 18} : null,
	isMarkdownEnabled ? {lineHeight: variables.lineHeightLarge} : null,

	function TextWithEmojiFragment({message, passedStyles, styleAsDeleted, styleAsMuted, isSmallScreenWidth, isEdited, emojisOnly}: ComponentProps) {

	function TextWithEmojiFragment({message, passedStyles, styleAsDeleted, styleAsMuted, isSmallScreenWidth, isEdited, emojisOnly}: ComponentProps) {

	passedStyles: StyleProp<TextStyle>;
	passedStyles?: StyleProp<TextStyle>;

Emojis larger in other contexts than just single character messages #40692

Emojis larger in other contexts than just single character messages #40692

Conversation

kbieganowski commented Apr 22, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Apr 23, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fabioh8010 Apr 24, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fabioh8010 Apr 26, 2024 • edited Loading

Choose a reason for hiding this comment

kbieganowski commented May 7, 2024

fabioh8010 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fabioh8010 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

melvin-bot bot commented May 16, 2024

VickyStash commented Jul 26, 2024

OSBotify commented Jul 27, 2024

parasharrajat commented Jul 27, 2024

VickyStash commented Jul 29, 2024

VickyStash commented Jul 29, 2024

parasharrajat commented Jul 29, 2024

VickyStash commented Jul 29, 2024

OSBotify commented Jul 29, 2024

OSBotify commented Jul 31, 2024

kbieganowski commented Apr 22, 2024 •

edited

Loading

fabioh8010 Apr 24, 2024 •

edited

Loading

fabioh8010 Apr 26, 2024 •

edited

Loading