Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] iOS - Composer - Emoji is cut off when entering one letter after the emoji #46444

Closed
1 of 6 tasks
lanitochka17 opened this issue Jul 29, 2024 · 14 comments
Closed
1 of 6 tasks
Assignees
Labels
Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Hourly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Jul 29, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.14-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Launch New Expensify app
  2. Open any chat
  3. Enter an emoji
  4. Type one letter after the emoji

Expected Result:

The emoji will not be cut off when entering one letter after the emoji

Actual Result:

The emoji is cut off when entering one letter after the emoji
When entering the second letter, it appears normal again

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6556577_1722281096020.ScreenRecording_07-30-2024_03-21-12_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01eb22e4ceda4fdcb9
  • Upwork Job ID: 1818025070545665675
  • Last Price Increase: 2024-07-29
Issue OwnerCurrent Issue Owner: @hungvu193
@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API labels Jul 29, 2024
Copy link

melvin-bot bot commented Jul 29, 2024

Triggered auto assignment to @francoisl (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsp

@francoisl
Copy link
Contributor

Could be from #40692. Looks like there's another blocker (#46443) related to that PR already.

@francoisl francoisl added the External Added to denote the issue can be worked on by a contributor label Jul 29, 2024
@melvin-bot melvin-bot bot changed the title iOS - Composer - Emoji is cut off when entering one letter after the emoji [$250] iOS - Composer - Emoji is cut off when entering one letter after the emoji Jul 29, 2024
Copy link

melvin-bot bot commented Jul 29, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01eb22e4ceda4fdcb9

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 29, 2024
Copy link

melvin-bot bot commented Jul 29, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

@ShridharGoel
Copy link
Contributor

My proposal should fix this issue as well.

Copy link

melvin-bot bot commented Jul 29, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@chiragsalian
Copy link
Contributor

Issue not related to web-e repo so removing deployblocker label.

@chiragsalian chiragsalian removed the DeployBlocker Indicates it should block deploying the API label Jul 29, 2024
@hungvu193
Copy link
Contributor

Seems it's being handled in #46443

@VickyStash
Copy link
Contributor

@parasharrajat
The reason of the described problem is that the markdownStyles update with the new fontSize for the emojis isn't applied right away on ios.

I'm able to reproduce the same behavior in the react-native-live-markdown lib. It looks like the markdownStyles update on iOS applies to the input only after the value update (something new got entered). So markdownStyles update doesn't re-render the input.

See the video:

mardown_bug.mp4

@parasharrajat
Copy link
Member

Yeah, we should fix this on lib level. We also discussed this on the main PR.

@parasharrajat parasharrajat mentioned this issue Jul 30, 2024
50 tasks
@parasharrajat
Copy link
Member

We can close this issue. the PR was reverted.

@francoisl francoisl removed the DeployBlockerCash This issue or pull request should block deployment label Jul 30, 2024
@francoisl
Copy link
Contributor

For future reference, here was the revert PR #46463

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Hourly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants