Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2024-05-29 #42741

Closed
github-actions bot opened this issue May 29, 2024 · 16 comments
Closed

Deploy Checklist: New Expensify 2024-05-29 #42741

github-actions bot opened this issue May 29, 2024 · 16 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@github-actions
Copy link
Contributor

github-actions bot commented May 29, 2024

Release Version: 1.4.77-11
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@Beamanator Beamanator added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label May 29, 2024
@OSBotify
Copy link
Contributor

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.77-0 🚀

@Julesssss
Copy link
Contributor

Removing #42755 as a blocker as it's a minor UI problem

@kbecciv
Copy link

kbecciv commented May 29, 2024

Prod QA #42264 and #42267 - checking off,

@mountiny
Copy link
Contributor

demoted #42750

@kbecciv
Copy link

kbecciv commented May 29, 2024

@mountiny Can this PR #38571 be verified internally? left comment - #38571 (comment)

@amyevans
Copy link
Contributor

Checking off #42764

@francoisl
Copy link
Contributor

Checking off #42780, fix tested on staging.

@rlinoz
Copy link
Contributor

rlinoz commented May 29, 2024

Checking off #42768, revert fixed it.

@jasperhuangg
Copy link
Contributor

Checking off #42778, was fixed in staging

@kbecciv
Copy link

kbecciv commented May 29, 2024

TR is 40% left

#25604 - pending verification
#35045 - pending verification in mWeb and Desktop
#38571 - Can this PR be verified internally?
#40182 - pending verification on Desktop
#40766 - pending verification on Desktop and IOS app
#41633 - pending verification
#41647 - pending verification
#42018 - pending verification on Desktop
#42026 is failing with #42789 on Android app, repro in Prod - checking off
#42088 - pending verification
#42124 - pending verification
#42183 - pending verification
#42257 - pending verification
#42285 is vailing with #42751 on mWeb and Android app
#42313 - pending verification
#42332 - pending verification
#42337 - pending verification
#42339 - pending verification
#42342 - pending verification
#42364 - pending verification on Desktop
#42398 - pending verification on Desktop
#42513 is failing with #42751 on IOS app

Deploy Blockers:
#42751
#42752
#42766
#42767
#42795

@Beamanator
Copy link
Contributor

#42752 fixed by #42773, checking off both!

@kbecciv
Copy link

kbecciv commented May 30, 2024

TR is 5% left

#25604 is failing with #24074 on Web, mWeb and Desktop
#38571 left comment #38571 (comment)
#41633 - pending verification on IOS app
#42026 is failing with #42789 on Android app, repro in Prod - checking off
#42257 - pending verification on Desktop
#42285 is failing with #42751 on mWeb and Android
#42342 is failing with #42800 on Web and Android app, and failing with #42800 and #42802 on IOS app
#42513 is failing with #42751 on IOS app

Deploy Blockers:
#42751
#42766
#42795
#42800
#42802
#42822

@mountiny
Copy link
Contributor

Checking #25604 off, discussing in the issue itself not a blocker

@kbecciv
Copy link

kbecciv commented May 30, 2024

Regression is completed!

#25604 is failing with #24074 on Web, mWeb and Desktop
#38571 left comment #38571 (comment)
#42026 is failing with #42789 on Android app, repro in Prod - checking off
#42285 is failing with #42751 on mWeb and Android
#42342 is failing with #42800 on Web and Android app, and failing with #42800 and #42802 on IOS app
#42513 is failing with #42751 on IOS app
#25604 is failing with #24074 on Web, mWeb and Desktop
#38571 left comment #38571 (comment)
#42026 is failing with #42789 on Android app, repro in Prod - checking off
#42285 is failing with #42751 on mWeb and Android
#42342 is failing with #42800 on Web and Android app, and failing with #42800 and #42802 on IOS app
#42513 is failing with #42751 on IOS app

Deploy Blockers:
#42766
#42795

@kbecciv
Copy link

kbecciv commented May 30, 2024

Checking off last Deploy blocker #42766, no longer reproduced after revert #42766 (comment)

@puneetlath
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests