Fix Group Chat Avatar Offline Feedback in Chat #42088

nexarvo · 2024-05-13T16:19:25Z

Details

Fixed Issues

$ #41770
PROPOSAL: #41770 (comment)

Tests

Group Chat Grayed out Case:

Go to any group chat.
Click on the header > Report Details Page.
Go offline.
Click on the avatar
Change the avatar.
Go back to group chat
Verify that the group chat avatar in the Report is grayed out.

Profile Setting Page > Avatar edit is not Grayed out Case:

Go to Profile Setting Page.
Go offline.
Click on the avatar
Change the avatar.
Verify that the edit / pencil icon is not grayed out.

Workspace Setting Page > Avatar edit is not Grayed out Case:

Go to Workspace Setting Page.
Go offline.
Click on the avatar
Change the avatar.
Verify that the edit / pencil icon is not grayed out.

Group Chat Details Page > Avatar edit is not Grayed out Case:

Go to Group Chat Details Page.
Go offline.
Click on the avatar
Change the avatar.
Verify that the edit / pencil icon is not grayed out.

Verify that no errors appear in the JS console

Offline tests

Same as Tests.

QA Steps

Group Chat Grayed out Case:

Go to any group chat.
Click on the header > Report Details Page .
Go offline.
Click on the avatar
Change the avatar.
Go back to group chat
Verify that the group chat avatar in the Report is grayed out.

Profile Setting Page > Avatar edit is not Grayed out Case:

Go to Profile Setting Page.
Go offline.
Click on the avatar
Change the avatar.
Verify that the edit / pencil icon is not grayed out.

Workspace Setting Page > Avatar edit is not Grayed out Case:

Go to Workspace Setting Page.
Go offline.
Click on the avatar
Change the avatar.
Verify that the edit / pencil icon is not grayed out.

Group Chat Details Page > Avatar edit is not Grayed out Case:

Go to Group Chat Details Page.
Go offline.
Click on the avatar
Change the avatar.
Verify that the edit / pencil icon is not grayed out.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Report avatar is grayed out:

Edit Icon in Profile Setting page is not grayed out:

Edit Icon in Workspace Setting page is not grayed out:

Android: mWeb Chrome

Report avatar is grayed out:

Edit Icon in Profile Setting page is not grayed out:

Edit Icon in Workspace Setting page is not grayed out:

iOS: Native

Getting build errors.

iOS: mWeb Safari

Report avatar is grayed out:
Edit Icon in Profile Setting page is not grayed out:
Edit Icon in Workspace Setting page is not grayed out:

MacOS: Chrome / Safari

Report avatar is grayed out:

Screen.20Recording.202024-05-14.20at.2012.mp4

Edit Icon in Profile Setting page is not grayed out:

Screen.20Recording.202024-05-14.20at.2012-2.mp4

Edit Icon in Workspace Setting page is not grayed out:

Screen.20Recording.202024-05-14.20at.2012-3.mp4

MacOS: Desktop

Report avatar is grayed out:

Edit Icon in Profile Setting page is not grayed out:

Edit Icon in Workspace Setting page is not grayed out:

melvin-bot · 2024-05-13T16:19:31Z

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

nexarvo · 2024-05-13T16:30:37Z

Hi @s77rt, There are a few things I wanted to confirm:

Do we need to show error message for avatar in report? Here:

Asking this because we are updating the avatar in report details page and we are showing error there.

2. We don't need to show error message for avatar in report header and LHN right ?

3. Do we need to implement offline feedback for avatar in tooltip ? Here:

nexarvo · 2024-05-13T16:31:28Z

Also, I will complete the checklist once PR is complete.

s77rt · 2024-05-13T18:21:04Z

For 1 and 2: The error should show only on the place where we can edit the avatar.
For 3: Test with the profile avatar and apply the opacity for report avatar only if it's applied for profile avatar

s77rt · 2024-05-14T10:09:48Z

This broke the error message on Settings and Workspace Profile pages (issue also exists on ReportDetails in native but it may have different root cause, don't focus on this one)

nexarvo · 2024-05-14T12:03:30Z

Taking a look into this now. I think changing the errorRowStyles passed to AvatarWithImagePicker should fix this problem.

nexarvo · 2024-05-14T12:33:30Z

@s77rt I just checked out main and it seems that the workspace error is already broken there:

Can you please confirm if you are getting same issue in main. Thanks.

s77rt · 2024-05-14T13:46:02Z

The error is an array, you probably types a string, try with errors={["error goes here message"]}

nexarvo · 2024-05-14T14:26:13Z

Thanks for catching that. The error message is fixed now at every place.

s77rt · 2024-05-14T19:51:15Z

src/components/AvatarWithImagePicker.tsx

-                                    <DefaultAvatar />
-                                )}
-                            </View>
+                            <OfflineWithFeedback pendingAction={pendingAction}>


Why do we have two OfflineWithFeedback?

We only want to apply pendingAction to avatar. But if we apply error in the second OfflineWithFeedback then it messes with the overall styles of error message. That's why I removed pendingAction from the first OfflineWithFeedback and it will only responsible to show errors if any. If we only apply OfflineWithFeedback to avatar only then we need to change the style of error message and I tried different padding and margins also but it was not working. The error message overlaps with the title and description as well here.

Having two OfflineWithFeedback for the same underlaying component feels like a workaround. Can you get ride of one of them and try to fix the error message? (try use styles.w100 if it helps)

Hi @s77rt, I have tried a couple of ways to resolve this issue and some of them worked as well but they broke some other stuff. We will need to refactor the whole AvatarWithImagePicker component to make this work. We are already using multiple OfflineFeedback for error and pending action like in this file:

App/src/components/ReportActionItem/TaskView.tsx

Lines 65 to 71 in d67f0e4

<OfflineWithFeedback

shouldShowErrorMessages

errors={report.errorFields?.editTask ?? report.errorFields?.createTask}

onClose={() => Task.clearTaskErrors(report.reportID)}

errorRowStyles={styles.ph5}

>

<Hoverable>

And for only pendingAction:

App/src/components/ReportActionItem/TaskView.tsx

Lines 94 to 95 in d67f0e4

<OfflineWithFeedback pendingAction={report.pendingFields?.reportName}>

<Text style={styles.taskTitleDescription}>{translate('task.title')}</Text>

My suggestion is we use 2 OfflineFeedback as we are already using this way in other places in the App. Please let me know if there is any better approach for this ?

@nexarvo Let's not block on that. Can you just remove the extra wrapping View that's inside <OfflineWithFeedback />

Removed extra view in this commit

marcaaron · 2024-05-23T00:48:13Z

@nexarvo Everything good here? It's been a week since this comment.

s77rt · 2024-05-23T22:14:01Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

android.2.mov

Android: mWeb Chrome

Networking issue

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

s77rt · 2024-05-23T22:15:47Z

@nexarvo Please fix the first test, we don't need to go to the Members page. Also please check #42088 (comment). Once this is resolved please tag me

nexarvo · 2024-05-23T22:36:34Z

@s77rt changes are done.

marcaaron

LGTM!

OSBotify · 2024-05-29T09:42:54Z

🚀 Deployed to staging by https://github.com/marcaaron in version: 1.4.77-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-05-30T21:25:43Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.77-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-05-30T22:37:41Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.77-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

nexarvo added 5 commits May 13, 2024 21:12

add offline feedback for group avatar in report

ade046e

add offline feedback for group avatar in header

bc439be

add offline feedback for group avatar in LHN

1bdda1c

remove offline feedback from edit icon

99e0ed3

remove offline feedback from avatar edit icon in profile setting page

2432680

nexarvo requested a review from a team as a code owner May 13, 2024 16:19

melvin-bot bot requested review from s77rt and removed request for a team May 13, 2024 16:19

nexarvo added 2 commits May 14, 2024 00:13

revert offline feedback for avatar in LHN

8848d08

fix lint

ce676eb

nexarvo added 2 commits May 14, 2024 19:21

fix error message style

c218f42

fix lint

d67f0e4

s77rt reviewed May 14, 2024

View reviewed changes

s77rt mentioned this pull request May 17, 2024

[$250] [HOLD for payment 2024-06-11] Uploading a Group Chat custom avatar that is too large shows badly formatted error message #40199

Closed

Christinadobrzyn mentioned this pull request May 21, 2024

[HOLD for payment 2024-06-06] [$250] Group details – Avatar is not grayed out in a group chat when change it Offline #41770

Closed

6 tasks

remove extra view

058815a

s77rt approved these changes May 23, 2024

View reviewed changes

melvin-bot bot requested a review from marcaaron May 23, 2024 22:45

marcaaron approved these changes May 28, 2024

View reviewed changes

marcaaron merged commit 9830f15 into Expensify:main May 28, 2024
17 checks passed

github-actions bot mentioned this pull request May 29, 2024

Deploy Checklist: New Expensify 2024-05-29 #42741

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Group Chat Avatar Offline Feedback in Chat #42088

Fix Group Chat Avatar Offline Feedback in Chat #42088

nexarvo commented May 13, 2024 •

edited

Loading

melvin-bot bot commented May 13, 2024

nexarvo commented May 13, 2024

nexarvo commented May 13, 2024

s77rt commented May 13, 2024

s77rt commented May 14, 2024

nexarvo commented May 14, 2024

nexarvo commented May 14, 2024 •

edited

Loading

s77rt commented May 14, 2024 •

edited

Loading

nexarvo commented May 14, 2024

s77rt May 14, 2024

nexarvo May 14, 2024 •

edited

Loading

s77rt May 15, 2024

nexarvo May 23, 2024

s77rt May 23, 2024

nexarvo May 23, 2024

marcaaron commented May 23, 2024

s77rt commented May 23, 2024

s77rt commented May 23, 2024

nexarvo commented May 23, 2024

marcaaron left a comment

OSBotify commented May 29, 2024

OSBotify commented May 30, 2024

OSBotify commented May 30, 2024

	<OfflineWithFeedback
	shouldShowErrorMessages
	errors={report.errorFields?.editTask ?? report.errorFields?.createTask}
	onClose={() => Task.clearTaskErrors(report.reportID)}
	errorRowStyles={styles.ph5}
	>
	<Hoverable>

	<OfflineWithFeedback pendingAction={report.pendingFields?.reportName}>
	<Text style={styles.taskTitleDescription}>{translate('task.title')}</Text>

Fix Group Chat Avatar Offline Feedback in Chat #42088

Fix Group Chat Avatar Offline Feedback in Chat #42088

Conversation

nexarvo commented May 13, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 13, 2024

nexarvo commented May 13, 2024

nexarvo commented May 13, 2024

s77rt commented May 13, 2024

s77rt commented May 14, 2024

nexarvo commented May 14, 2024

nexarvo commented May 14, 2024 • edited Loading

s77rt commented May 14, 2024 • edited Loading

nexarvo commented May 14, 2024

s77rt May 14, 2024

Choose a reason for hiding this comment

nexarvo May 14, 2024 • edited Loading

Choose a reason for hiding this comment

s77rt May 15, 2024

Choose a reason for hiding this comment

nexarvo May 23, 2024

Choose a reason for hiding this comment

s77rt May 23, 2024

Choose a reason for hiding this comment

nexarvo May 23, 2024

Choose a reason for hiding this comment

marcaaron commented May 23, 2024

s77rt commented May 23, 2024

Reviewer Checklist

Screenshots/Videos

s77rt commented May 23, 2024

nexarvo commented May 23, 2024

marcaaron left a comment

Choose a reason for hiding this comment

OSBotify commented May 29, 2024

OSBotify commented May 30, 2024

OSBotify commented May 30, 2024

nexarvo commented May 13, 2024 •

edited

Loading

nexarvo commented May 14, 2024 •

edited

Loading

s77rt commented May 14, 2024 •

edited

Loading

nexarvo May 14, 2024 •

edited

Loading