[HOLD for payment 2024-07-10] [$250] Android - Room - Room background is severely cut off when created offline

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.76-0
Reproducible in staging?: Y
Reproducible in production?: N
Found when executing PR : #35045
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to staging.new.expensify.com
2. Go offline.
3. Go to FAB > Start chat > Room
4. Create a room.

Expected Result:

The background image in room will not be severely cut off.

Actual Result:

The background image in room is severely cut off.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6495009_1716980965422.Screen_Recording_20240529_190443_New_Expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01542e8b76660e8c22
• Upwork Job ID: 1798696161576342702
• Last Price Increase: 2024-06-06
• Automatic offers:
• jjcoffee | Reviewer | 102706529

Issue Owner

Current Issue Owner: @mallenexpensify

[melvin-bot]

Triggered auto assignment to @flodnv (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@mallenexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #vip-vsb.

[izarutskaya]

Production

[puneetlath]

This feels like a minor UI issue. I think it doesn't need to block the deploy.

[mallenexpensify]

I agree this doesn't need to be a deploy blocker. Looks like @luacmartins removed the label so I'm bumping to Daily.
Tried multiple times to reproduce on Android via BrowserStack with no luck.

[flodnv]

Sorry, what is cutoff? I don't see it 😕

[mallenexpensify]

The bug in the OP is this

and the way it's supposed to look is to have the full background image, like here

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01542e8b76660e8c22

[jnowakow]

Sorry for lack of activity on this issue but in the meantime I moved my focus to regressions that were caused by focus trap.
I haven't found the root cause for this issue yet but traces lead to ExpoImage.

[melvin-bot]

@flodnv, @mallenexpensify, @jjcoffee, @jnowakow Eep! 4 days overdue now. Issues have feelings too...

[mallenexpensify]

Thanks @jnowakow , I bumped it to weekly, it's not a high priority issue.

[jjcoffee]

PR approved by me.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix new offline chat image on android #43895

If no regressions arise, payment will be issued on 2024-07-10. 🎊

For reference, here are some details about the assignees on this issue:

• @jjcoffee requires payment automatic offer (Reviewer)
• @jnowakow does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@flodnv] The PR that introduced the bug has been identified. Link to the PR:
• [@flodnv] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@flodnv] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@jjcoffee / @jnowakow] Determine if we should create a regression test for this bug.
• [@jjcoffee / @jnowakow] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[jjcoffee]

• The PR that introduced the bug has been identified. Link to the PR: Fixed offline Android overlapping icons #23710
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/23710/files#r1671779151
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug. Yes
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Go offline
2. Create new room chat
3. Verify that the chat's background image is displayed correctly without any cut-off

Do we agree 👍 or 👎

[mallenexpensify]

Contributor+: @jjcoffee paid $250 via Upwork.

Thx for the TestRail steps, issue created

• https://github.com/Expensify/Expensify/issues/411945