Fix: No error message when entering a invalid email #17254

dukenv0307 · 2023-04-11T09:28:04Z

Details

No error message when entering a invalid email for a new chat

Fixed Issues

$ #16884
PROPOSAL: #16884 (comment)

Tests

Login with any account
Click on the green plus icon and choose New chat
Enter a invalid email (i.e new1:1@test.com)
Verify "Invalid email" error message is displayed
Switch to Spanish and verify 'Email inválido' is displayed

Verify that no errors appear in the JS console

Offline tests

Same above

QA Steps

Login with any account
Click on the green plus icon and choose New chat
Enter a invalid email (i.e new1:1@test.com)
Verify "Invalid email" error message is displayed
Switch to Spanish and verify 'Email inválido' is displayed

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screencast.from.11-04-2023.15.00.12.webm

Mobile Web - Chrome

Record_2023-04-11-15-01-20.mp4

Mobile Web - Safari

Desktop

iOS

Android

16884.mp4

MelvinBot · 2023-04-11T17:54:54Z

@Beamanator Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dukenv0307 · 2023-04-11T18:37:55Z

@Beamanator This is my first PR, please help to take a look at it and enable 10 workflows awaiting approval

fedirjh · 2023-04-11T21:41:33Z

src/languages/en.js

@@ -98,6 +98,7 @@ export default {
            characterLimit: ({limit}) => `Exceeds the maximum length of ${limit} characters`,
            dateInvalid: 'Please enter a valid date',
            invalidCharacter: 'Invalid character',
+            invalidEmail: 'Invalid email',


@dukenv0307 We can create a custom message similar to errorMessageInvalidPhone inside messages , may @neil-marcellini confirm it

@fedirjh just wondering, why do you prefer having the error message inside messages instead of here? I feel like here makes more sense since this is a generic set of errors

@Beamanator It's just for consistency , errorMessageInvalidPhone is located here, so we could also move it inside common.errors to maintain consistency

App/src/languages/en.js

Lines 757 to 759 in 4624631

messages: {

errorMessageInvalidPhone: `Please enter a valid phone number without brackets or dashes. If you're outside the US please include your country code (e.g. ${CONST.EXAMPLE_PHONE_NUMBER}).`,

},

@fedirjh Do you want the invalidEmail message similar to errorMessageInvalidPhone inside messages or leave it as it is?

@dukenv0307 I will defer that to @neil-marcellini.

I would put it inside messages because it's more of an informative message rather than an error message, but it's not a big deal either way.

fedirjh · 2023-04-11T23:11:51Z

src/languages/es.js

@@ -97,6 +97,7 @@ export default {
            characterLimit: ({limit}) => `Supera el límite de ${limit} caracteres`,
            dateInvalid: 'Ingresa una fecha válida',
            invalidCharacter: 'Caracter invalida',
+            invalidEmail: 'Email inválido',


@dukenv0307, as this is your first PR, I would like to draw your attention to a checklist item that needs to be considered.

I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy

Therefore, we need to request a review for the correct copy on the original GitHub issue.

fedirjh · 2023-04-12T01:43:41Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

fedirjh · 2023-04-12T03:55:41Z

@Beamanator I think this should be assigned to @neil-marcellini.

Beamanator · 2023-04-12T08:28:32Z

@neil-marcellini assigning you since it seems you were assigned on the original issue (thanks for pointing that out @fedirjh )

neil-marcellini

Look good overall. I left a few small comments. We're also waiting for copy. I'll review again once we have the copy locked down.

neil-marcellini · 2023-04-12T18:07:29Z

src/languages/en.js

@@ -98,6 +98,7 @@ export default {
            characterLimit: ({limit}) => `Exceeds the maximum length of ${limit} characters`,
            dateInvalid: 'Please enter a valid date',
            invalidCharacter: 'Invalid character',
+            invalidEmail: 'Invalid email',


I would put it inside messages because it's more of an informative message rather than an error message, but it's not a big deal either way.

src/libs/OptionsListUtils.js

dukenv0307 · 2023-04-13T09:30:53Z

@Beamanator @neil-marcellini Should we hold this PR until the correct copy is confirmed

Beamanator · 2023-04-13T10:41:02Z

(FYI I'm not planning to review this since I'm OOO - but I couldn't remove myself from the Reviewers list lol 🤷 )

dukenv0307 · 2023-04-17T03:09:29Z

@neil-marcellini I saw Davidcardoza confirmed that the message of invalid email is "Invalid email". Actually it's set to Invalid email in English and Email inválido in Spanish
#16884 (comment)
And I moved it inside messages please check again

fedirjh

LGTM based on #16884 (comment) 🚀

cc @neil-marcellini

🎀👀🎀 C+ reviewed

OSBotify · 2023-04-17T17:06:38Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-04-18T04:39:03Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.3.1-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-04-18T06:08:39Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.3.1-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-04-19T17:21:48Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.1-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

dukenv0307 marked this pull request as ready for review April 11, 2023 17:54

dukenv0307 requested a review from a team as a code owner April 11, 2023 17:54

melvin-bot bot requested review from Beamanator and removed request for a team April 11, 2023 17:54

dukenv0307 mentioned this pull request Apr 11, 2023

[$1000] No error message when entering an invalid email for a new chat #16884

Closed

6 tasks

fedirjh reviewed Apr 11, 2023

View reviewed changes

Beamanator requested review from neil-marcellini and removed request for Beamanator April 12, 2023 08:27

neil-marcellini reviewed Apr 12, 2023

View reviewed changes

Beamanator requested review from Beamanator and removed request for Beamanator April 13, 2023 10:40

dukenv0307 added 3 commits April 13, 2023 23:35

Fix: No error message when entering a invalid email

08611dd

format code

dc61257

move invalidEmail message inside messages

65ac54f

dukenv0307 force-pushed the fix/16884-no-error-message-when-entering-a-invalid-email branch from 18b2924 to 65ac54f Compare April 13, 2023 16:37

fedirjh approved these changes Apr 17, 2023

View reviewed changes

neil-marcellini approved these changes Apr 17, 2023

View reviewed changes

neil-marcellini merged commit c994994 into Expensify:main Apr 17, 2023

OSBotify mentioned this pull request Apr 17, 2023

Deploy Checklist: New Expensify 2023-04-17 #17546

Closed

53 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: No error message when entering a invalid email #17254

Fix: No error message when entering a invalid email #17254

dukenv0307 commented Apr 11, 2023 •

edited

Loading

MelvinBot commented Apr 11, 2023

dukenv0307 commented Apr 11, 2023

fedirjh Apr 11, 2023

Beamanator Apr 11, 2023

fedirjh Apr 11, 2023

dukenv0307 Apr 12, 2023

fedirjh Apr 12, 2023

neil-marcellini Apr 12, 2023

fedirjh Apr 11, 2023

fedirjh commented Apr 12, 2023 •

edited

Loading

fedirjh commented Apr 12, 2023

Beamanator commented Apr 12, 2023

neil-marcellini left a comment

neil-marcellini Apr 12, 2023

dukenv0307 commented Apr 13, 2023 •

edited

Loading

Beamanator commented Apr 13, 2023

dukenv0307 commented Apr 17, 2023 •

edited

Loading

fedirjh left a comment

OSBotify commented Apr 17, 2023

OSBotify commented Apr 18, 2023

OSBotify commented Apr 18, 2023

OSBotify commented Apr 19, 2023

	messages: {
	errorMessageInvalidPhone: `Please enter a valid phone number without brackets or dashes. If you're outside the US please include your country code (e.g. ${CONST.EXAMPLE_PHONE_NUMBER}).`,
	},

Fix: No error message when entering a invalid email #17254

Fix: No error message when entering a invalid email #17254

Conversation

dukenv0307 commented Apr 11, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

MelvinBot commented Apr 11, 2023

dukenv0307 commented Apr 11, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fedirjh commented Apr 12, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

fedirjh commented Apr 12, 2023

Beamanator commented Apr 12, 2023

neil-marcellini left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dukenv0307 commented Apr 13, 2023 • edited Loading

Beamanator commented Apr 13, 2023

dukenv0307 commented Apr 17, 2023 • edited Loading

fedirjh left a comment

Choose a reason for hiding this comment

OSBotify commented Apr 17, 2023

OSBotify commented Apr 18, 2023

OSBotify commented Apr 18, 2023

OSBotify commented Apr 19, 2023

dukenv0307 commented Apr 11, 2023 •

edited

Loading

fedirjh commented Apr 12, 2023 •

edited

Loading

dukenv0307 commented Apr 13, 2023 •

edited

Loading

dukenv0307 commented Apr 17, 2023 •

edited

Loading