Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[$1000] No error message when entering an invalid email for a new chat #16884

Closed
6 tasks done
kavimuru opened this issue Apr 3, 2023 · 50 comments
Closed
6 tasks done

[$1000] No error message when entering an invalid email for a new chat #16884

kavimuru opened this issue Apr 3, 2023 · 50 comments
Assignees
@alexpensify @neil-marcellini @fedirjh @dukenv0307
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review

Comments

@kavimuru
Copy link

kavimuru commented Apr 3, 2023 •
edited by melvin-bot bot
Loading

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

  1. Sign in with any account
  2. Click the green plus, New chat
  3. Enter new1:1@test.com

Expected Result:

An “Invalid email” error message is displayed

Actual Result:

“No results found” is displayed but there’s no other indication that this is an invalid email

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.93-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

image (1)

4Untitled

Expensify/Expensify Issue URL:
Issue reported by: @neil-marcellini
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680540207948259
View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0132343b72b9eb2960
  • Upwork Job ID: 1645492852104339456
  • Last Price Increase: 2023-04-10
@kavimuru kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 3, 2023
@MelvinBot
Copy link

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot
Copy link

MelvinBot commented Apr 3, 2023 •
edited by alexpensify
Loading

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot melvin-bot bot added the Overdue label Apr 6, 2023
@neil-marcellini
Copy link
Contributor

@kavimuru why did you unassign @NicMendonca?

@melvin-bot melvin-bot bot removed the Overdue label Apr 6, 2023
@neil-marcellini neil-marcellini added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Apr 6, 2023
@MelvinBot
Copy link

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot
Copy link

MelvinBot commented Apr 6, 2023 •
edited by alexpensify
Loading

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@neil-marcellini
Copy link
Contributor

I assigned a new bug zero member since Nicole is OOO for a bit.

@kavimuru
Copy link
Author

kavimuru commented Apr 7, 2023

@neil-marcellini I thought you want to take care of this issue.

@neil-marcellini
Copy link
Contributor

Yes. Each issue is assigned a bug zero member to handle the people side of things, and a internal engineer to help the contributors.

@melvin-bot melvin-bot bot added the Overdue label Apr 10, 2023
@neil-marcellini
Copy link
Contributor

Bump @alexpensify

@melvin-bot melvin-bot bot removed the Overdue label Apr 10, 2023
@alexpensify
Copy link
Contributor

Due to the Holiday weekend, we have a low number of Concierge teammembers online, I've had to prioritize Concierge Ops over Bug Zero. I'll try to get to this one later today.

@alexpensify
Copy link
Contributor

I was able to replicate

image

@alexpensify alexpensify added the External Added to denote the issue can be worked on by a contributor label Apr 10, 2023
@melvin-bot melvin-bot bot changed the title No error message when entering an invalid email for a new chat [$1000] No error message when entering an invalid email for a new chat Apr 10, 2023
@MelvinBot
Copy link

Job added to Upwork: https://www.upwork.com/jobs/~0132343b72b9eb2960

@MelvinBot
Copy link

Current assignee @alexpensify is eligible for the External assigner, not assigning anyone new.

@MelvinBot
Copy link

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 10, 2023
@MelvinBot
Copy link

Triggered auto assignment to @davidcardoza (Waiting for copy), see https://stackoverflow.com/c/expensify/questions/7025/ for more details.

@neil-marcellini
Copy link
Contributor

I would also like a Spanish translation please.

@davidcardoza
Copy link
Contributor

Should we describe why the email is invalid - "This email is invalid due to incorrect formatting" ?

@neil-marcellini
Copy link
Contributor

That feels a bit redundant to me. Why else would it be invalid? Maybe we could say "Invalid email. Please check for typos and try again."

I kind of prefer simply "Invalid email".

@davidcardoza
Copy link
Contributor

Cool, let’s go with "invalid email"

@dukenv0307
Copy link
Contributor

Regression Test Proposal

Bug: No error message when entering an invalid email for a new chat

Proposed Test Steps:

  1. Login with any account
  2. Click on the green plus icon and choose New chat
  3. Enter a invalid email (i.e new1:1@test.com)
  4. Verify "Invalid email" error message is displayed
  5. Switch to Spanish and verify 'Email inválido' is displayed

Do we 👍 or 👎

@neil-marcellini
Copy link
Contributor

IMO this is not worth the effort to test, it's not that critical.

@alexpensify
Copy link
Contributor

@neil-marcellini and @fedirjh - since there is no testing, is this one ready for payment? I think the automation is off on this one because we are skipping the regression period testing.

@fedirjh
Copy link
Contributor

fedirjh commented Apr 21, 2023

is this one ready for payment?

I believe it is still in the regression period and payment should be made on the 26th. It was deployed to prod on the 19th

@alexpensify
Copy link
Contributor

Thanks, I'll add a reminder for that day.

@alexpensify alexpensify removed the Waiting for copy User facing verbiage needs polishing label Apr 24, 2023
@alexpensify
Copy link
Contributor

I've removed David C. and the copy requirement since this one is in the works now.

@alexpensify
Copy link
Contributor

Alright, we hit the 26th. @neil-marcellini and @fedirjh - any pushback on moving to payment since the automation didn't run here to update the GitHub state?

@fedirjh
Copy link
Contributor

fedirjh commented Apr 27, 2023

@alexpensify No regressions were found during the regression period, so it's ready for payment.

@alexpensify
Copy link
Contributor

Thank you for the update @fedirjh! I'll work on the payment process tomorrow.

@alexpensify
Copy link
Contributor

I saw this in another GH and want to give it a try here to ensure that the payment is correct.

We have the following payouts. I see there is no 50% bonus or penalty because it was assigned #16884 (comment) on April 11 and was merged on April 17:

Issue reporter: $250 - N/A (Internal)
Contributor: $1,000 - @dukenv0307
Contributor+: $1,000- @fedirjh

@neil-marcellini or @fedirjh - Can you please 👍🏼 if you agree and I'll complete the next steps in Upwork. Thank you!

@fedirjh
Copy link
Contributor

fedirjh commented Apr 29, 2023

@alexpensify That's correct, No bonus applicable for this issue.

@alexpensify
Copy link
Contributor

Alright, all payments have been prepared in Upwork and are pending approval from the contributors. I'll finish the process as soon as everyone signs off in Upwork. Thanks!

@alexpensify
Copy link
Contributor

Everyone has been paid via Upwork and I've closed the job, so I'm closing the GH too.

@dukenv0307
Copy link
Contributor

@fedirjh @alexpensify Hi just checking since we have a hold period where we wait for the correct copy for the error message starting on Apr 13 and ending on Apr 16, would that be considered in the PR timeline calculation? If excluding that hold period then I think the PR is merged within 3 business days.

@neil-marcellini
Copy link
Contributor

There's nothing you could do to speed up waiting for copy, so I don't think we should count it towards the PR timeline.

@dukenv0307
Copy link
Contributor

Thanks! @neil-marcellini

There's nothing you could do to speed up waiting for copy, so I don't think we should count it towards the PR timeline.

@alexpensify With that in mind can you reconsider if PR urgency bonus is applicable here? If excluding the "waiting for copy" period, the PR is merged within 3 business days.

@alexpensify
Copy link
Contributor

@dukenv0307 - please give me a day to review again, because I shared the payouts here: #16884 (comment). I need to find my notes for this GH.

@alexpensify
Copy link
Contributor

Alright, I'm going to issue a $500 urgency bonus to:

Contributor: @dukenv0307
Contributor+: @fedirjh

Please reply if you disagree or have other feedback, I'll work on the payment process tomorrow. Thanks!

@alexpensify
Copy link
Contributor

I've sent the offers in Upwork, please accept and I can complete the process. Thank you!

@dukenv0307
Copy link
Contributor

@alexpensify accepted, thank you!

@alexpensify
Copy link
Contributor

Alright, everyone has been paid out via Upwork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexpensify alexpensify

@neil-marcellini neil-marcellini

@fedirjh fedirjh

@dukenv0307 dukenv0307

Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@davidcardoza @alexpensify @MelvinBot @NicMendonca @neil-marcellini @fedirjh @kavimuru @dukenv0307