Deploy Checklist: New Expensify 2023-04-17

[OSBotify]

Release Version: 1.3.1-3
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Allow keyboard shortcuts to work on native devices #14767
• New Branding - New Sign In Imagery #15737
• Remove duplicate offline indicator from set password page #16457
• Remove duplicate error message for UpdateWorkspaceCustomUnit #16564
• [HOOKS REFACTOR] Refactor Expensify.js to use hooks #16664
• Add Push-to-Page support for IOUConfirmationList #16919
• [Manual Requests] [No QA] Add OpenMoneyRequestsReportPage command #16926
• fix: 15131 html decode in lhn and iou #16957
• Clean-up dupe button styles  #17087
• fix: prevent page reload when same link is opened from footer #17119
• Workspaces in money request modal #17132
• fix/16098: Listen keydown from user to focus again the composer #17138
• Fix: Blank space on the right side of tooltip #17218
• Send homeAddressStreet parameter to prevent autoformatting #17220
• Fix: No error message when entering a invalid email #17254
• [PayPal.me Button] Show Pay with PayPal button for supported countries only #17283
• Tooltip functionality behaving weird for the copy to clipboard #17286
• Fix Spanish copy in a few places #17302
• fix: long press app download links on mweb Safari to open the Copy to Clipboard menu #17310
• fix: update component when the report status num changes #17319
• Fix: Not update edited message on LHN in offline mode #17324
• prevent re-uploading avatar when press enter key multiple times #17326
• fix/16420: text selection inconsistency in ReportScreen #17330
• Fix: workspace chat shows the timezone and name of the admin #17332
• Fix: Link has been sent text dynamic translation on login screens #17351
• Fix: don't focus when key pressed in combination #17360
• feat: Added textBreakStrategy simple to resend page email #17383
• fix checkbox incorrect focus outline #17385
• [NO QA] Add route for expensify lounge page #17393
• add vertical spacing to avoid outline getting cut off in Address Search input #17403
• Offline emoji suggestion opacity fix #17405
• Re-titled one of the playbooks #17406
• Update checklist item #17407
• Fix: crash and replace the space with margin #17412
• Show alert when doing more than 1 write in auth in the backend #17415
• fix storybook errors on Forms and PopoverMenu #17443
• Clear errors when delete a chat/action #17444
• Fix null issue in lastMessageText #17449
• update react native picker select #17456
• Composer field left border extend vertically as it expand and collapse #17464
• Revert: 17138 17360 listen keydown from user #17475
• Fix: Regression of console error #17494
• Fix: Smaller screens - Double click to close phone popup reopens the popup #17498
• Fix/17212: Also update html message and get last message in LHN when edit offline #17586
• Revert "Allow keyboard shortcuts to work on native devices" #17592
• Revert "Merge pull request #17310 from akinwale/task-16946" #17618

Internal QA:

• Fix expensify devportal url replacement #17448 - @pubudu-ranasinghe

Deploy Blockers:

• [HOLD for payment 2023-04-27] LHN edited message UI shows the whole multiline message for a few seconds #17574
• [HOLD for payment 2023-04-27] [HOLD for payment 2023-04-26] Workspace - When deleting a workspace offline. the layout breaks #17580
• [HOLD for payment 2023-05-16] [$1000] DEV: Mobile - Right icon of menu item is misaligned #17601

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.1-0 🚀

[mvtglobally]

@mountiny ios app is still not updated

[mountiny]

@mvtglobally correct, it was rejected by apple, there is a CP running no which should hopefully resolve that

[mvtglobally]

Thanks for checking @mountiny . We are running other platforms for now. Checklist is enormous this time. 😜

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.1-1 🚀

[MelvinBot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.1-1 has been deployed to staging 🎉

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.1-2 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.1-2 has been deployed to staging 🎉

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.1-3 🚀

[mountiny]

Checking #17601 off, not a deploy blocker

#17580 revert was CPed to staging and I have confirmed it works

QAed the internalQA and confirmed it works #17448

This is also fixed in staging #17574

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.1-3 has been deployed to staging 🎉

[mvtglobally]

@mountiny regression is completed

PR #15737 is failing #17575. Not repro in prod, but as a new feature we didn't add blocker label
PR #16564 is failing #17576. Repro in PROd checking off
PR #16664 is failing #17638 repro in PROD
PR #16957 is failing #17577. Not repro in prod
PR #17132 is failing #17653, not repro in prod
PR #17138 is failing #17604. Repro in prod checking off
PR #17310 is failing #17641. PR seem to be reverted, are we ok to check off?
PR #17385 is failing #17631. Repro in prod, checking off
PR can you check it internally? This also seems like PROD QA #17406
PR #17444 is failing #17587 repro in prod & #17650 (very inconsistent can you double check)
PR #17464 is failing #17424. Repro in prod
PR #17618 is failing #17656.

[mountiny]

PR #17310 is failing #17641. PR seem to be reverted, are we ok to check off?

Reverted, checking off

[mountiny]

PR can you check it internally? This also seems like PROD QA #17406

Yes, helpdot is prod qa, checking off

[mountiny]

Checking off #17444 since the failing case is repro in prod

[mountiny]

Checking #17132 off since this is currently worked on feature behind beta.

[mountiny]

Checking #15737 off the list, the raised issue seems to be only linked to Windows and their browser and its not a blocker.

[mountiny]

Checked #17618 off seems like a minor design issue and we will try to address it in a follow up PR

[mountiny]

Checking #17464 off since its repro in prod

[mountiny]

Checking #16664 off since its repro in production

[mountiny]

Checking #16957 off the linked issue is not a deploy blocker if its an issue at all

[mountiny]

And checking of #17326 since the linked issue also does not look like a deploy blocker.

[mountiny]

Graphs and crashes look good, deploying

[mountiny]