-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-05-04] [$1000] Connect Bank - Tab button is not fully outlining the address box when the address is long #17631
Comments
Triggered auto assignment to @lschurr ( |
Bug0 Triage Checklist (Main S/O)
|
I didn't find this task on Upwork, but maybe my proposal here will be good and I'll get this or any other task from you. Here we need to play with CSS of the div where the text is placed.
Of course, if this solution fits the design expectations. |
I was able to reproduce on Chrome. |
Triggered auto assignment to @thienlnam ( |
Shall we make this external @thienlnam? |
Job added to Upwork: https://www.upwork.com/jobs/~01eddd79237cf9a606 |
Current assignee @lschurr is eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif ( |
Current assignee @thienlnam is eligible for the External assigner, not assigning anyone new. |
ProposalPlease re-state the problem that we are trying to solve in this issue.Tab is outline to the overflowed content bcoz it is scrollable What is the root cause of that problem?Currently, the option is scrollable horizontally which takes full width of the available content. What changes do you think we should make in order to solve the problem?We need to add prop App/src/components/AddressSearch.js Line 205 in da79423
Result Screen.Recording.2023-04-19.at.11.08.21.PM.mov |
ProposalPlease re-state the problem that we are trying to solve in this issue.We are trying to show the right side blue highlight of address option when focused via tab. What is the root cause of that problem?The options in What changes do you think we should make in order to solve the problem?I think its design related and the expected result should be confirmed from the design team. We could show the full address, maybe wrap it on next line by adding What alternative solutions did you explore? (Optional)N/A |
ProposalPlease re-state the problem that we are trying to solve in this issue.right outline border is hidden when address is long and highlighted by TAB What is the root cause of that problem?Highlight is coming from Pressable and ScrollView is inside Pressable so outline involves entire scrollable row What changes do you think we should make in order to solve the problem?Swap ScrollView and Pressable so that outline involves only visible view demo.mov |
@aimane-chnaif can you review these proposals? |
All 3 proposals above work but depending on design choice, we can pick one up.
|
Thanks @shawnborton @thienlnam let's go with @huzaifa-99's proposal as it's the most close. 🎀 👀 🎀 C+ reviewed |
📣 @huzaifa-99 You have been assigned to this job by @lschurr! |
Thank you for the review @aimane-chnaif @shawnborton @thienlnam. PR will be up in a short while |
PR up for review #17942. And also as @shawnborton had suggested here, I updated the code to truncate address after two lines with an ellipsis |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.6-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-05-04. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
@aimane-chnaif and @huzaifa-99 can you apply for the job in Upwork? https://www.upwork.com/jobs/~01eddd79237cf9a606 |
@Ischurr Applied thanks |
@Ischurr Am I eligible for the 3 day merge bouns? |
Yep! As long as there are no regressions before the payout date, a bonus will be applied @huzaifa-99 |
@aimane-chnaif do we need a regression test for this one? |
No PR caused regression. The issue was from library (actually not bug). |
All paid, going to close! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Issue found when executing PR #17403
Action Performed:
Expected Result:
User expects there to be a full blue outline on every suggested address
Actual Result:
On long suggestions, the blue box shows as incomplete on the right hand border
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.1.1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug6022816_Border_is_incomplete_for_long_results.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: