-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Blank space on the right side of tooltip #17218
Fix: Blank space on the right side of tooltip #17218
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
7c62e51
to
cc08931
Compare
I have read the CLA Document and I hereby sign the CLA |
recheck |
cc08931
to
b96c516
Compare
937f850
to
3ee00a3
Compare
@puneetlath @mollfpr One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Hi @puneetlath I am a new contributor. Could you help to enable the 18 workflows awaiting approval ? |
@puneetlath I understand it wrong; I think it still needs your approval to run the workflow. |
Reviewer Checklist
Screenshots/VideosWeb17218.Web.movMobile Web - ChromeMobile Web - SafariDesktop17218.Desktop.moviOSAndroid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some clarification comments to clear up the solution.
format code Co-authored-by: Luthfi <luthfi.ufi14@gmail.com>
@dukenv0307 Test well for me. Could you add a note to the test case where this can only test on the Web/Desktop? |
@mollfpr Just updated the Test and QA step |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@puneetlath Friendly bump, Please help to check my PR and enable awaiting workflows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/puneetlath in version: 1.3.1-0 🚀
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.3.1-3 🚀
|
Details
The tooltip of the group profile is displaying a blank space on the right sight.
Fixed Issues
$ #16800
PROPOSAL: #16800 (comment)
Tests
Note: This PR only could be tested on desktop web and desktop app
Offline tests
Same above
QA Steps
Note: This PR only could be tested on desktop web and desktop app
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Screencast.from.11-04-2023.10.25.04.webm
Mobile Web - Chrome
NAMobile Web - Safari
NADesktop
iOS
NAAndroid
NA