Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[input time zone] Update and re-organize timezone dropdown options for improved usability #9018

Closed
2 of 6 tasks
emmilaakso212 opened this issue Mar 29, 2024 · 12 comments
Closed
2 of 6 tasks
Assignees
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 8 Requires input from team, consider smaller steps. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality ready for dev Issues ready for development implementation.

Comments

@emmilaakso212
Copy link

emmilaakso212 commented Mar 29, 2024

Check existing issues

Description

As a user who wants to select a time zone using the time zone picker, I want to be able to easily identify which time zone is relevant to me.

Acceptance Criteria

Replace "name" mode of the time zone picker with a new version, or create this as a third version, if needed.

Content:

Add the following data to timezone options:

Content order:

  • Show dropdown items in format of city, state/province*, country* [UTC-offset]
  • Group timezone data by continent, and show continent name once as a group label
  • Organize dropdown results alphabetically by city name (some timezones/offsets will appear more than once. That’s ok)

*optional content

UI/behavior

  • If timezone picker had an existing value, by default scroll in the results such that the previous value is at the top
  • Allow searching within the options by city, state or province, country, or offset

See Figma for designs

Relevant Info

Agreed upon enhancement work for Map Viewer team for implementation by 24-R3

Which Component

Time zone picker

Example Use Case

No response

Priority impact

impact - p2 - want for an upcoming milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Map Viewer

Related issues

@emmilaakso212 emmilaakso212 added 0 - new New issues that need assignment. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review. labels Mar 29, 2024
@github-actions github-actions bot added impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. labels Mar 29, 2024
@emmilaakso212
Copy link
Author

cc: @jcfranco

@geospatialem geospatialem added design Issues that need design consultation prior to development. ready for dev Issues ready for development implementation. labels Apr 18, 2024
@github-actions github-actions bot added the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Apr 18, 2024
Copy link
Contributor

cc @geospatialem, @brittneytewks

@geospatialem geospatialem added p - high Issue should be addressed in the current milestone, impacts component or core functionality and removed needs triage Planning workflow - pending design/dev review. labels Apr 18, 2024
@jcfranco jcfranco added the estimate - 5 A few days of work, definitely requires updates to tests. label Apr 18, 2024
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Apr 18, 2024
@geospatialem
Copy link
Member

Aiming for dev implementation prior to R3 based on Online priorities - currently targeted for May. cc @emmilaakso212

@AdelheidF
Copy link

I guess this won't make it for Online release R2 then, unfortunately.

@jcfranco jcfranco self-assigned this May 1, 2024
@jcfranco jcfranco added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels May 1, 2024
@geospatialem geospatialem added estimate - 8 Requires input from team, consider smaller steps. and removed estimate - 5 A few days of work, definitely requires updates to tests. labels May 13, 2024
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. epic Large scale issues to be broken up into sub-issues and tracked via sprints and/or project. and removed 1 - assigned Issues that are assigned to a sprint and a team member. epic Large scale issues to be broken up into sub-issues and tracked via sprints and/or project. labels May 24, 2024
@jcfranco
Copy link
Member

Belated update on this one, the following enhancements to combobox have been addressed this release to match the proposed design spec:

The following are adjustments to the original requirements (per conversation w/ @emmilaakso212 and @ashetland):

  1. Country and city will be the only additions for now.
  2. Options will be grouped by IANA region and not continent per se.
  3. Time zones should not be duplicated due to DST as this new mode will be primarily geographically-driven (searching by region, continent, country, etc.).
  4. The dropdown already displays the selected value when opened, so no adjustments needed.
  5. We'll consider using the exiting Intl offset format vs using decimal format.
  6. Offset can be displayed as is (i.e., no need to change from () to []) since it will be displayed differently once Enhancement: Subtitle/description for combobox-item #3695 lands.
  7. We'll consider changing the offsetStyle default in a breaking change release. For now, internal apps need to opt into using UTC.

The grouping and additional metadata for improved search UX will be tackled in the July release.

@jcfranco
Copy link
Member

FWIW, this got pushed to August for additional testing, but here's a preview: https://codepen.io/jcfranco/pen/rNEjyQJ. It should be available via @next sometime this week.

@AdelheidF
Copy link

AdelheidF commented Jul 31, 2024

Does this include an update to the messages_xx.json files to also include some type of region information so we can have a unified and more readable format/way of displaying the current time zone in various components?

image

@jcfranco
Copy link
Member

jcfranco commented Aug 1, 2024

Do you mean metadata behind each time zone option? If so, that wasn't a part of the original request. In the new mode, the time zone options are grouped by region using timezone-groups behind the scenes.

FWIW, timezone-groups will have some enhancements coming up soon to provide additional utils for this.

jcfranco added a commit that referenced this issue Aug 1, 2024
**Related Issue:** #9018

## Summary

Adds new `region` mode to display time zones by IANA-defined region.

### Notes

* bumps `timezone-groups` to latest version, which supports multiple
grouping options
* adds translation entries for countries (country code ([ISO
3166](https://www.iso.org/iso-3166-country-codes.html)) is used as keys)
* IANA timezones are used the `value`
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Aug 1, 2024
Copy link
Contributor

github-actions bot commented Aug 1, 2024

Installed and assigned for verification.

@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned jcfranco Aug 1, 2024
jcfranco added a commit that referenced this issue Aug 2, 2024
**Related Issue:** #9018

## Summary

Adds missing region translations.
@DitwanP
Copy link
Contributor

DitwanP commented Aug 5, 2024

🍡 Verified on 2.12.0-next.4

@DitwanP DitwanP closed this as completed Aug 5, 2024
@DitwanP DitwanP reopened this Aug 5, 2024
@DitwanP
Copy link
Contributor

DitwanP commented Aug 5, 2024

Sorry @jcfranco I missed something here, did we still want to make it so the selected value is shown at the top of the dropdown when it opens? As it is now I see it at the bottom:
image

I'm referring to this btw:
"If timezone picker had an existing value, by default scroll in the results such that the previous value is at the top"

@jcfranco
Copy link
Member

jcfranco commented Aug 5, 2024

This is expected. We revised this after meeting w/ @emmilaakso212 and @ashetland. From an earlier comment:

  1. The dropdown already displays the selected value when opened, so no adjustments needed.

@DitwanP DitwanP closed this as completed Aug 5, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 8 Requires input from team, consider smaller steps. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality ready for dev Issues ready for development implementation.
Projects
None yet
Development

No branches or pull requests

5 participants