Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combobox/Combobox-item - allow filtering by textLabel only #8043

Closed
2 of 5 tasks
ian13262 opened this issue Oct 23, 2023 · 5 comments
Closed
2 of 5 tasks

Combobox/Combobox-item - allow filtering by textLabel only #8043

ian13262 opened this issue Oct 23, 2023 · 5 comments
Assignees
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Online Issues logged by ArcGIS Online team members. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library

Comments

@ian13262
Copy link

Check existing issues

Description

For calcite-combobox-items with significantly different value and textLabel properties, it would be helpful to only allow filtering by textLabel rather than the underlying value as well.

This prevents confusing situations like this in which value is an English string and textLabel is a localized string in a different language:
image

Applies to any use case where, for some reason (uniqueness, localization, etc.), value and textLabel are quite different.

Acceptance Criteria

A new property on calcite-combobox would be helpful (something like filterMode = "value" | "text-label", defaulting to both if not specified).

Relevant Info

No response

Which Component

calcite-combobox, calcite-combobox-item

Example Use Case

See above

Priority impact

p4 - not time sensitive

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Online

@ian13262 ian13262 added 0 - new New issues that need assignment. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review. labels Oct 23, 2023
@github-actions github-actions bot added impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive calcite-components Issues specific to the @esri/calcite-components package. ArcGIS Online Issues logged by ArcGIS Online team members. labels Oct 23, 2023
@geospatialem
Copy link
Member

Related #7176

@jcfranco
Copy link
Member

Combobox should follow the same approach from #9622.

Worth noting that the default behavior of including value in filtering will likely change in v3 (see #9615).

@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library estimate - 3 A day or two of work, likely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment. and removed needs triage Planning workflow - pending design/dev review. labels Jun 25, 2024
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Jun 25, 2024
@geospatialem
Copy link
Member

Determine if could be coupled with #9018 for R3, or if we need to tackle for 25.R1.

@geospatialem geospatialem added this to the 2025-01-28 - Jan Release milestone Aug 7, 2024
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Aug 7, 2024
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment. labels Dec 31, 2024
jcfranco added a commit that referenced this issue Jan 2, 2025
**Related Issue:** #8043 

## Summary

This provides more flexibility for filtering combobox items and groups.
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 1 - assigned Issues that are assigned to a sprint and a team member. 2 - in development Issues that are actively being worked on. labels Jan 2, 2025
Copy link
Contributor

github-actions bot commented Jan 2, 2025

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jan 3, 2025
@geospatialem
Copy link
Member

Verified with https://codepen.io/geospatialem/pen/PwYOmOj in 3.0.0-next.88 with the combobox's new filterProps property:

document.querySelector("calcite-combobox").filterProps = ["textLabel", "description"];

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Online Issues logged by ArcGIS Online team members. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Development

No branches or pull requests

4 participants