Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(input-time-zone): add region mode #9873

Merged
merged 9 commits into from
Aug 1, 2024
Merged

feat(input-time-zone): add region mode #9873

merged 9 commits into from
Aug 1, 2024

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Jul 29, 2024 •
edited
Loading

Related Issue: #9018

Summary

Adds new region mode to display time zones by IANA-defined region.

Notes

  • bumps timezone-groups to latest version, which supports multiple grouping options
  • adds translation entries for countries (country code (ISO 3166) is used as keys)
  • IANA timezones are used the value

@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jul 29, 2024
@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Jul 29, 2024
@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Jul 29, 2024
@jcfranco jcfranco removed the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jul 29, 2024
@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jul 29, 2024
@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Jul 30, 2024
@jcfranco jcfranco marked this pull request as ready for review July 31, 2024 00:56
@jcfranco jcfranco requested a review from benelan as a code owner July 31, 2024 00:56
@jcfranco jcfranco requested review from driskull and ashetland July 31, 2024 00:56
driskull
driskull approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Jul 31, 2024
@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Jul 31, 2024
@ashetland
Copy link
Contributor

noice

@jcfranco jcfranco merged commit 7111a51 into dev Aug 1, 2024
13 of 14 checks passed
@jcfranco jcfranco deleted the jcfranco/6590-add-time-zone-region-mode branch August 1, 2024 21:53
@github-actions github-actions bot added this to the 2.11.1 patch milestone Aug 1, 2024
@benelan benelan mentioned this pull request Aug 28, 2024
Merged
@calcite-admin calcite-admin mentioned this pull request Sep 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashetland ashetland ashetland approved these changes

@driskull driskull driskull approved these changes

@benelan benelan Awaiting requested review from benelan benelan is a code owner

Assignees

@jcfranco jcfranco

Labels
enhancement Issues tied to a new feature or request. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
2024-08-27 - Aug Release
Development

Successfully merging this pull request may close these issues.
4 participants
@jcfranco @ashetland @driskull @geospatialem