-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use dev version for examples when running tests #33
Conversation
It seems to me, that with this approach, we may end up again at the old problem with write permissions when one used |
What was the problem with write permissions? That you were not allowed to add the Manifest file? Could we run it in a temporary environment, perhaps? |
Rethinking about it, it should work. However, we need to:
If it is not working, we can reverse it in another minor increase. However, we need to register it to be certain that it is working. |
We concluded in offline discussion that we prefer to set a flag in ENV to toggle use of development version explicitly for tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. We can use the same approach in all other packages in my opinion.
Using a heuristic for whether the code is checked out and not installed is to check if the containing folder includes the full package name, ending with
.jl
.Let's see if it works on github. I'm sure there is a better way to check if a package is installed or checked out? The idea is to develop the package if checked out locally or in CI, and use the registered version otherwise.