Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dev version for examples when running tests #33

Merged
merged 3 commits into from
Jun 12, 2024

Conversation

hellemo
Copy link
Member

@hellemo hellemo commented Jun 10, 2024

Using a heuristic for whether the code is checked out and not installed is to check if the containing folder includes the full package name, ending with .jl.
Let's see if it works on github. I'm sure there is a better way to check if a package is installed or checked out? The idea is to develop the package if checked out locally or in CI, and use the registered version otherwise.

@hellemo hellemo mentioned this pull request Jun 10, 2024
@JulStraus
Copy link
Member

It seems to me, that with this approach, we may end up again at the old problem with write permissions when one used ] add.

@hellemo
Copy link
Member Author

hellemo commented Jun 11, 2024

What was the problem with write permissions? That you were not allowed to add the Manifest file? Could we run it in a temporary environment, perhaps?

@JulStraus
Copy link
Member

Rethinking about it, it should work. However, we need to:

  1. Update the NEWS.md and
  2. Increase the minor version.

If it is not working, we can reverse it in another minor increase. However, we need to register it to be certain that it is working.

@hellemo hellemo changed the title Use dev version if path includes full package name (with .jl") Use dev version for examples when running tests Jun 11, 2024
@hellemo hellemo requested a review from JulStraus June 11, 2024 12:57
@hellemo hellemo self-assigned this Jun 11, 2024
@hellemo hellemo added the bug Something isn't working label Jun 11, 2024
@hellemo
Copy link
Member Author

hellemo commented Jun 11, 2024

We concluded in offline discussion that we prefer to set a flag in ENV to toggle use of development version explicitly for tests.
Fixes #17

Copy link
Member

@JulStraus JulStraus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. We can use the same approach in all other packages in my opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants