-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Running examples #17
Comments
Two options that come to mind are:
|
Point 1 would definitely work, although it would require minor changes in the Point 2 is a bit more interesting to check out. In practice, we cannot test whether it works except if we have it registered. Otherwise, we will never run in the potential problem that there is no possibility for overriding in a folder we do not have the right to override. I checked that out with a local version in which I called the functions for running the examples. In this situation, the problem was that is also used |
When exactly do we want to run with the development version? I assume for CI and when we are running tests locally for new versions? One alternative could be to use an explicit flag to turn this on, e.g. like if haskey(ENV, "EMB_TEST_OR_CI")
@info "only for test or CI"
end and set the appropriate environment variable as part of the tests, but will not be run by default. |
After testing the directory of an added package, I think it can work: julia> using EnergyModelsBase
julia> exdir = joinpath(pkgdir(EnergyModelsBase), "examples")
"\\.julia\\packages\\EnergyModelsBase\\XtYXL\\examples" as it does not include the .jl ending, when added. |
The current change in the examples allow to run these from a version of
EnergyModelsBase
included from the registry through PR14. However, a problem now arises for testing the examples. In practice, the tests no longer utilize the version that is the latest, but instead the latest version from the Registry. When testing locally, this problem does not occur, but when testing on GitHub, that can become a problem.Hence, we should find a solution with the following properties:
Thoughts?
The text was updated successfully, but these errors were encountered: