Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dev version for examples when running tests #20

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

hellemo
Copy link
Member

@hellemo hellemo commented Jun 17, 2024

Corresponding to EnergyModelsX/EnergyModelsBase.jl#33 and EnergyModelsX/EnergyModelsInvestments.jl#29

  • Use dev version when testing examples
  • Do not print results when testing

Do not print results when testing
@hellemo hellemo requested a review from JulStraus June 17, 2024 14:50
Copy link
Member

@JulStraus JulStraus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

We did not care so much regarding the printing previously, as the tests are just running on CI, but I can understand that for local testing, it is easier to find the errors. It is however uglier in the reading of the file, unfortunately.

@JulStraus JulStraus changed the title Use dev version when testing examples Use dev version for examples when running tests Jun 18, 2024
@JulStraus JulStraus merged commit d4856aa into main Jun 18, 2024
6 checks passed
@JulStraus JulStraus deleted the lh/use_dev_version_when_testing_examples branch June 18, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants