Qual: ci: Run pre-commit/php-cs with cache #28079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldy
reviewed
Feb 9, 2024
| @@ -17,8 +18,7 @@ | |||
| <exclude-pattern type="relative">*/nltechno*</exclude-pattern> | |||
| <exclude-pattern type="relative">source</exclude-pattern> | |||
| <exclude-pattern type="relative">.git</exclude-pattern> | |||
| <exclude-pattern>htdocs/includes</exclude-pattern> | |||
There was a problem hiding this comment.
This directory contains code that we do not control. They are external sources.
So if we apoly the dolibarr rule checks on it, we should get a lot of errors, shouldn't we ?
There was a problem hiding this comment.
I agree about the directory but it's already excluded in a rule above + I updated the configuration to run only on php files so that php-cs can be run using only the ruleset.xml file as the configuration.
We had these two lines, and I removed the second one and the checks are fine.
eldy
added
the
Discussion
mdeweerd
force-pushed
the
php-cs/cache
branch
2 times, most recently
from
214604e to
e16b20d
Compare
This adds a hook to .pre-commit-config.yaml and updates the workflow to run php-cs with cache when it is run for all files. When running on changed files only, the cache is not useful. The php-codesniffer ruleset.xml was cleaned up (duplicates removal/formatted)
mdeweerd
force-pushed
the
php-cs/cache
branch
from
e16b20d to
76497e9
Compare
mdeweerd
added a commit
to mdeweerd/dolibarr
that referenced
this pull request
Feb 11, 2024
This adds a hook to .pre-commit-config.yaml and updates the workflow to run php-cs with cache when it is run for all files. When running on changed files only, the cache is not useful. The php-codesniffer ruleset.xml was cleaned up (duplicates removal/formatted)
eldy
pushed a commit
that referenced
this pull request
Feb 12, 2024
* Qual: Lower severity on php-cs messages that should not block (#28072) # Qual: Lower severity on php-cs messages that should not block Some warning messages result in php-cs having an exit code of 2 and others only have an exit ocde of 1. When the exit code is 2, the warnings are fixable by php-cbf. In order to be able to filter on the warnings in the github ci flow, but still show them in the travis flow, I lower the level of the warnings that should not be blocking to 4. At the same time, the php-cs configuration in pre-commit now requires that the severity is minimum 5 to show the message (level 5 is the default for all warnings and errors). So this will limit the warning messages to the ones that should result in a failing ci action. If any new cases are discovered, they should also be lowered in the php-cs configuration file. * Qual: ci: Run pre-commit/php-cs with cache (#28079) This adds a hook to .pre-commit-config.yaml and updates the workflow to run php-cs with cache when it is run for all files. When running on changed files only, the cache is not useful. The php-codesniffer ruleset.xml was cleaned up (duplicates removal/formatted)
mdeweerd
added a commit
to mdeweerd/dolibarr
that referenced
this pull request
Mar 3, 2024
This adds a hook to .pre-commit-config.yaml and updates the workflow to run php-cs with cache when it is run for all files. When running on changed files only, the cache is not useful. The php-codesniffer ruleset.xml was cleaned up (duplicates removal/formatted)
eldy
pushed a commit
that referenced
this pull request
Mar 4, 2024
* Qual: ci: Run pre-commit/php-cs with cache (#28079) This adds a hook to .pre-commit-config.yaml and updates the workflow to run php-cs with cache when it is run for all files. When running on changed files only, the cache is not useful. The php-codesniffer ruleset.xml was cleaned up (duplicates removal/formatted) * Fix: Make all 'relative paths' absolute (#28196) # Fix: Make all 'relative paths' absolute The phpcs ruleset xml file's relative exclude patterns are relative to the filename(s) provided on the command line. Hence with partial verifications, the path exclusion does not function as we would like. Removing the relative-path attribute from the patterns the exclusion works. At the same time, the patterns were optimized and a comment was added. * Qual: Optimize workflow (#28386) # Qual: Optimize workflow The log annotation based on the pre-commit logs is now simplified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a hook to .pre-commit-config.yaml and updates the workflow to run php-cs with cache when it is run for all files. When running on changed files only, the cache is not useful.
The php-codesniffer ruleset.xml was cleaned up (duplicates removal/formatted)