Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qual: Optimize workflow #28386

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Conversation

mdeweerd
Copy link
Contributor

Qual: Optimize workflow

The log annotation based on the pre-commit logs is now simplified.

# Qual: Optimize workflow

The log annotation based on the pre-commit logs is now simplified.
@eldy eldy merged commit 6115d58 into Dolibarr:develop Feb 23, 2024
6 checks passed
@mdeweerd mdeweerd deleted the flow/use-log-to-cs-action branch February 23, 2024 19:06
mdeweerd added a commit to mdeweerd/dolibarr that referenced this pull request Mar 3, 2024
# Qual: Optimize workflow

The log annotation based on the pre-commit logs is now simplified.
eldy pushed a commit that referenced this pull request Mar 4, 2024
* Qual: ci: Run pre-commit/php-cs with cache (#28079)

This adds a hook to .pre-commit-config.yaml and updates the workflow
to run php-cs with cache when it is run for all files.
When running on changed files only, the cache is not useful.

The php-codesniffer ruleset.xml was cleaned up (duplicates removal/formatted)

* Fix: Make all 'relative paths' absolute (#28196)

# Fix: Make all 'relative paths' absolute

The phpcs ruleset xml file's relative exclude patterns are relative to
the filename(s) provided on the command line.
Hence with partial verifications, the path exclusion does not function
as we would like.
Removing the relative-path attribute from the patterns the exclusion
works.
At the same time, the patterns were optimized and a comment was added.

* Qual: Optimize workflow (#28386)

# Qual: Optimize workflow

The log annotation based on the pre-commit logs is now simplified.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants