Qual: Lower severity on php-cs messages that should not block #28072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Qual: Lower severity on php-cs messages that should not block Some warning messages result in php-cs having an exit code of 2 and others only have an exit ocde of 1. When the exit code is 2, the warnings are fixable by php-cbf. In order to be able to filter on the warnings in the github ci flow, but still show them in the travis flow, I lower the level of the warnings that should not be blocking to 4. At the same time, the php-cs configuration in pre-commit now requires that the severity is minimum 5 to show the message (level 5 is the default for all warnings and errors). So this will limit the warning messages to the ones that should result in a failing ci action. If any new cases are discovered, they should also be lowered in the php-cs configuration file.
mdeweerd
force-pushed
the
php-cs/lower-severity
branch
from
c24f05c to
a39a466
Compare
mdeweerd
added a commit
to mdeweerd/dolibarr
that referenced
this pull request
Feb 11, 2024
…rr#28072) # Qual: Lower severity on php-cs messages that should not block Some warning messages result in php-cs having an exit code of 2 and others only have an exit ocde of 1. When the exit code is 2, the warnings are fixable by php-cbf. In order to be able to filter on the warnings in the github ci flow, but still show them in the travis flow, I lower the level of the warnings that should not be blocking to 4. At the same time, the php-cs configuration in pre-commit now requires that the severity is minimum 5 to show the message (level 5 is the default for all warnings and errors). So this will limit the warning messages to the ones that should result in a failing ci action. If any new cases are discovered, they should also be lowered in the php-cs configuration file.
eldy
pushed a commit
that referenced
this pull request
Feb 12, 2024
* Qual: Lower severity on php-cs messages that should not block (#28072) # Qual: Lower severity on php-cs messages that should not block Some warning messages result in php-cs having an exit code of 2 and others only have an exit ocde of 1. When the exit code is 2, the warnings are fixable by php-cbf. In order to be able to filter on the warnings in the github ci flow, but still show them in the travis flow, I lower the level of the warnings that should not be blocking to 4. At the same time, the php-cs configuration in pre-commit now requires that the severity is minimum 5 to show the message (level 5 is the default for all warnings and errors). So this will limit the warning messages to the ones that should result in a failing ci action. If any new cases are discovered, they should also be lowered in the php-cs configuration file. * Qual: ci: Run pre-commit/php-cs with cache (#28079) This adds a hook to .pre-commit-config.yaml and updates the workflow to run php-cs with cache when it is run for all files. When running on changed files only, the cache is not useful. The php-codesniffer ruleset.xml was cleaned up (duplicates removal/formatted)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Qual: Lower severity on php-cs messages that should not block
Some warning messages result in php-cs having an exit code of 2 and others only have an exit ocde of 1. When the exit code is 2, the warnings are fixable by php-cbf.
In order to be able to filter on the warnings in the github ci flow, but still show them in the travis flow, I lower the level of the warnings that should not be blocking to 4.
At the same time, the php-cs configuration in pre-commit now requires that the severity is minimum 5 to show the message (level 5 is the default for all warnings and errors).
So this will limit the warning messages to the ones that should result in a failing ci action. If any new cases are discovered, they should also be lowered in the php-cs configuration file.