Upgrading Laravel Framework #1071

weerd · 2020-07-20T18:31:04Z

What's this PR do?

This pull request upgrades Rogue from Laravel 5.5 to Laravel 5.8!

How should this be reviewed?

👀

I didn't separate these commit by commit but I did try to leave useful notes as comments for some interesting tidbits or changes I got stuck on or where a bit more involved!

Any background context you want to provide?

🌵

Relevant tickets

References Pivotal #172383643.

Checklist

This PR has been added to the relevant Pivotal card.
Documentation added for new features/changed endpoints.
Added appropriate feature/unit tests.

app/Http/Middleware/TrustProxies.php

config/trustedproxy.php

weerd · 2020-07-20T18:33:43Z

Noting here that after the upgrades and running tests I was running into an odd error with tests that use the withAdminAccessToken() method.

Instead of the expected series of method calls, after the 5.6 updates, there is a resulting call to the __isset() magic method in the HasAttributes trait utilized by the RemoteUser class in our Gateway package.

The only thing I could find related in Laravel 5.6 changes was this merged pull request that adds an __isset() to the Optional class (we do use this class within Rogue and within the method calls related to withAdminAccessToken()).

Update: This issue was resolved by @DFurnes via an update to Gateway.

…avel provides same method.

app/Http/Controllers/PostsController.php

app/Policies/PostPolicy.php

weerd · 2020-07-28T19:35:23Z

Just FYI, this test is super finicky from recent experience and planning on rewriting it once I'm done with upgrades.

app.json

app/Providers/AppServiceProvider.php

DFurnes · 2020-07-29T14:36:59Z

config/database.php

+            // 'options' => extension_loaded('pdo_mysql') ? array_filter([
+            //     PDO::MYSQL_ATTR_SSL_CA => env('MYSQL_ATTR_SSL_CA'),
+            // ]) : [],


I'd love to do a bit more digging on this... betting it makes sense to keep, but curious what it's for!

The commit where it was added is not very helpful...

Ya, I think I had checked the commit and didn't see much info there, but didn't get a chance to dig further 🤷‍♂️

DFurnes

Wooooo! 🎉 Left a few comments, but looks fantastic all-in-all!!! Great work on all this!

…ack webhook in PHPUnit settings.

DFurnes

Looks perfect!!! 🎉

* Updating composer packages. * Updating dependencies. * Removing unused files and updating index.php * Updating .htaccess. * Removing bootstrap/autoload call. * Updating TrustedProxy settings. * Removing mentions of Dusk in project since no longer used. * Upadating Hashing config. * Updating Logging. * Updating logger method name. * Bringing rest of files up to date and in sync with 5.6 framework files. * Reverting web routes file I was using for debugging. * Figuring out issues with running tests. * Updating composer. * StyleCI fix. * Updating dependencies for 5.7. * Updating assets. * Updating authorization. * Updating cache. * Updating tests. * Removing overridden mock() method since the signature changed and Laravel provides same method. * Removing unused imported class. * Removing CustomGate now that framework supports Guest User Gates. * Fixing up broken tests. * Composer lock update. * Wrapping up miscellaneous updates from 5.6 to 5.7. * Some miscellaneous updates from 5.7 to 5.8. * Updating dependencies and fixing API routes. * Updating testing. * Updating notifications. * Updating support. * Updating support with env() changes. * Updating env example vars. * Updates to env vars used and simplifying redis env settings. * Fixing up Tag tests and errors with notifications. * Updating cache config. * Removing deleted_at from array since automatically converted after upgrades. * Changing tag so it does not trigger notification, if not point of test. * Cleanup. * Fixing StyleCI issue. * StyleCI fixes. * StyleCI fixes. * Updating Trusted Proxies based on Heroku docs. * Type-hinting the Authenticateable class works. * Updating redis options. * Updating filesystems config and reivew app config. * Adding note regarding a potential future update. * Restoring the Good Submission tag and setting empty string var for slack webhook in PHPUnit settings. * Restoring old approach now that tests do not trigger notifications. * Updaing AWS_* env variables.

* Removing CustomGate now that framework supports Guest User Gates. * Updating support. * Rebase fixes. * Rebase fixes. * Upgrading Laravel Framework (#1071) * Updating composer packages. * Updating dependencies. * Removing unused files and updating index.php * Updating .htaccess. * Removing bootstrap/autoload call. * Updating TrustedProxy settings. * Removing mentions of Dusk in project since no longer used. * Upadating Hashing config. * Updating Logging. * Updating logger method name. * Bringing rest of files up to date and in sync with 5.6 framework files. * Reverting web routes file I was using for debugging. * Figuring out issues with running tests. * Updating composer. * StyleCI fix. * Updating dependencies for 5.7. * Updating assets. * Updating authorization. * Updating cache. * Updating tests. * Removing overridden mock() method since the signature changed and Laravel provides same method. * Removing unused imported class. * Removing CustomGate now that framework supports Guest User Gates. * Fixing up broken tests. * Composer lock update. * Wrapping up miscellaneous updates from 5.6 to 5.7. * Some miscellaneous updates from 5.7 to 5.8. * Updating dependencies and fixing API routes. * Updating testing. * Updating notifications. * Updating support. * Updating support with env() changes. * Updating env example vars. * Updates to env vars used and simplifying redis env settings. * Fixing up Tag tests and errors with notifications. * Updating cache config. * Removing deleted_at from array since automatically converted after upgrades. * Changing tag so it does not trigger notification, if not point of test. * Cleanup. * Fixing StyleCI issue. * StyleCI fixes. * StyleCI fixes. * Updating Trusted Proxies based on Heroku docs. * Type-hinting the Authenticateable class works. * Updating redis options. * Updating filesystems config and reivew app config. * Adding note regarding a potential future update. * Restoring the Good Submission tag and setting empty string var for slack webhook in PHPUnit settings. * Restoring old approach now that tests do not trigger notifications. * Updaing AWS_* env variables. * Miscellaneous updates. * Updating miscellaneous. * Composer dependency updates. * Updating configuration. * Updating PHPUnit and fixing test with previously deprecated method. * Updating composer dependencies. * Reordering. * Cleanup. * Prefixing the SQS Env vars with AWS_ for consistency. * Post rebase cleanup * Fixing straggling merge conflicts. * Cleanup. * Updating url and endpoint settings.

* Updating composer packages. * Updating dependencies. * Removing unused files and updating index.php * Updating .htaccess. * Removing bootstrap/autoload call. * Updating TrustedProxy settings. * Removing mentions of Dusk in project since no longer used. * Upadating Hashing config. * Updating Logging. * Updating logger method name. * Bringing rest of files up to date and in sync with 5.6 framework files. * Reverting web routes file I was using for debugging. * Figuring out issues with running tests. * Updating composer. * StyleCI fix. * Updating dependencies for 5.7. * Updating assets. * Updating authorization. * Updating cache. * Updating tests. * Removing overridden mock() method since the signature changed and Laravel provides same method. * Removing unused imported class. * Removing CustomGate now that framework supports Guest User Gates. * Fixing up broken tests. * Composer lock update. * Wrapping up miscellaneous updates from 5.6 to 5.7. * Some miscellaneous updates from 5.7 to 5.8. * Updating dependencies and fixing API routes. * Updating testing. * Updating notifications. * Updating support. * Updating support with env() changes. * Updating env example vars. * Updates to env vars used and simplifying redis env settings. * Fixing up Tag tests and errors with notifications. * Updating cache config. * Removing deleted_at from array since automatically converted after upgrades. * Changing tag so it does not trigger notification, if not point of test. * Cleanup. * StyleCI fixes. * StyleCI fixes. * Updating Trusted Proxies based on Heroku docs. * Type-hinting the Authenticateable class works. * Updating redis options. * Updating filesystems config and reivew app config. * Adding note regarding a potential future update. * Restoring the Good Submission tag and setting empty string var for slack webhook in PHPUnit settings. * Restoring old approach now that tests do not trigger notifications. * Updaing AWS_* env variables. * Updating editorconfig file. * Upgrading Laravel Framework (#1071) * Updating composer packages. * Updating dependencies. * Removing unused files and updating index.php * Updating .htaccess. * Removing bootstrap/autoload call. * Updating TrustedProxy settings. * Removing mentions of Dusk in project since no longer used. * Upadating Hashing config. * Updating Logging. * Updating logger method name. * Bringing rest of files up to date and in sync with 5.6 framework files. * Reverting web routes file I was using for debugging. * Figuring out issues with running tests. * Updating composer. * StyleCI fix. * Updating dependencies for 5.7. * Updating assets. * Updating authorization. * Updating cache. * Updating tests. * Removing overridden mock() method since the signature changed and Laravel provides same method. * Removing unused imported class. * Removing CustomGate now that framework supports Guest User Gates. * Fixing up broken tests. * Composer lock update. * Wrapping up miscellaneous updates from 5.6 to 5.7. * Some miscellaneous updates from 5.7 to 5.8. * Updating dependencies and fixing API routes. * Updating testing. * Updating notifications. * Updating support. * Updating support with env() changes. * Updating env example vars. * Updates to env vars used and simplifying redis env settings. * Fixing up Tag tests and errors with notifications. * Updating cache config. * Removing deleted_at from array since automatically converted after upgrades. * Changing tag so it does not trigger notification, if not point of test. * Cleanup. * Fixing StyleCI issue. * StyleCI fixes. * StyleCI fixes. * Updating Trusted Proxies based on Heroku docs. * Type-hinting the Authenticateable class works. * Updating redis options. * Updating filesystems config and reivew app config. * Adding note regarding a potential future update. * Restoring the Good Submission tag and setting empty string var for slack webhook in PHPUnit settings. * Restoring old approach now that tests do not trigger notifications. * Updaing AWS_* env variables. * Restoring some items post rebase. * StyleCI fix. * Upgrading Laravel framework from 5.8 to 6.0 (#1081) * Removing CustomGate now that framework supports Guest User Gates. * Updating support. * Rebase fixes. * Rebase fixes. * Upgrading Laravel Framework (#1071) * Updating composer packages. * Updating dependencies. * Removing unused files and updating index.php * Updating .htaccess. * Removing bootstrap/autoload call. * Updating TrustedProxy settings. * Removing mentions of Dusk in project since no longer used. * Upadating Hashing config. * Updating Logging. * Updating logger method name. * Bringing rest of files up to date and in sync with 5.6 framework files. * Reverting web routes file I was using for debugging. * Figuring out issues with running tests. * Updating composer. * StyleCI fix. * Updating dependencies for 5.7. * Updating assets. * Updating authorization. * Updating cache. * Updating tests. * Removing overridden mock() method since the signature changed and Laravel provides same method. * Removing unused imported class. * Removing CustomGate now that framework supports Guest User Gates. * Fixing up broken tests. * Composer lock update. * Wrapping up miscellaneous updates from 5.6 to 5.7. * Some miscellaneous updates from 5.7 to 5.8. * Updating dependencies and fixing API routes. * Updating testing. * Updating notifications. * Updating support. * Updating support with env() changes. * Updating env example vars. * Updates to env vars used and simplifying redis env settings. * Fixing up Tag tests and errors with notifications. * Updating cache config. * Removing deleted_at from array since automatically converted after upgrades. * Changing tag so it does not trigger notification, if not point of test. * Cleanup. * Fixing StyleCI issue. * StyleCI fixes. * StyleCI fixes. * Updating Trusted Proxies based on Heroku docs. * Type-hinting the Authenticateable class works. * Updating redis options. * Updating filesystems config and reivew app config. * Adding note regarding a potential future update. * Restoring the Good Submission tag and setting empty string var for slack webhook in PHPUnit settings. * Restoring old approach now that tests do not trigger notifications. * Updaing AWS_* env variables. * Miscellaneous updates. * Updating miscellaneous. * Composer dependency updates. * Updating configuration. * Updating PHPUnit and fixing test with previously deprecated method. * Updating composer dependencies. * Reordering. * Cleanup. * Prefixing the SQS Env vars with AWS_ for consistency. * Post rebase cleanup * Fixing straggling merge conflicts. * Cleanup. * Updating url and endpoint settings.

weerd added 14 commits July 7, 2020 22:27

Updating composer packages.

04b8d9b

Updating dependencies.

15cbbba

Removing unused files and updating index.php

2dc7b8d

Updating .htaccess.

2fc52a3

Removing bootstrap/autoload call.

a299bed

Updating TrustedProxy settings.

7fe7dfb

Removing mentions of Dusk in project since no longer used.

0c77833

Upadating Hashing config.

8c0127f

Updating Logging.

05cc009

Updating logger method name.

c356a02

Bringing rest of files up to date and in sync with 5.6 framework files.

9ac1c52

Reverting web routes file I was using for debugging.

123258b

Figuring out issues with running tests.

3198f2e

Updating composer.

bb78b4c

weerd commented Jul 20, 2020

View reviewed changes

app/Http/Middleware/TrustProxies.php Outdated Show resolved Hide resolved

weerd commented Jul 20, 2020

View reviewed changes

config/trustedproxy.php Show resolved Hide resolved

weerd mentioned this pull request Jul 20, 2020

Upgrade to Laravel 5.6 #1063

Closed

3 tasks

weerd added 10 commits July 20, 2020 14:40

StyleCI fix.

8ada9ae

Updating dependencies for 5.7.

9f3865d

Updating assets.

4be7a98

Updating authorization.

c2af8ef

Updating cache.

ed89b54

Updating tests.

96118e2

Removing overridden mock() method since the signature changed and Lar…

4a2da82

…avel provides same method.

Removing unused imported class.

19bafd9

Removing CustomGate now that framework supports Guest User Gates.

2b294d0

Fixing up broken tests.

ee07c28

weerd commented Jul 23, 2020

View reviewed changes

app/Http/Controllers/PostsController.php Show resolved Hide resolved

weerd commented Jul 23, 2020

View reviewed changes

app/Policies/PostPolicy.php Outdated Show resolved Hide resolved

weerd added 2 commits July 28, 2020 14:50

StyleCI fixes.

31d07f7

StyleCI fixes.

99c0746

weerd marked this pull request as ready for review July 28, 2020 20:31

weerd requested a review from a team as a code owner July 28, 2020 20:31

weerd requested review from Dinnall and DFurnes and removed request for a team and Dinnall July 28, 2020 20:31

DFurnes reviewed Jul 29, 2020

View reviewed changes

app.json Outdated Show resolved Hide resolved

DFurnes reviewed Jul 29, 2020

View reviewed changes

app/Providers/AppServiceProvider.php Show resolved Hide resolved

DFurnes reviewed Jul 29, 2020

View reviewed changes

Updating Trusted Proxies based on Heroku docs.

8b1c4eb

DFurnes approved these changes Jul 29, 2020

View reviewed changes

weerd added 5 commits July 29, 2020 11:26

Type-hinting the Authenticateable class works.

88b74cd

Updating redis options.

f433f03

Updating filesystems config and reivew app config.

cddadb2

Adding note regarding a potential future update.

3e16a73

Restoring the Good Submission tag and setting empty string var for sl…

c93b144

…ack webhook in PHPUnit settings.

DFurnes approved these changes Jul 29, 2020

View reviewed changes

weerd added 2 commits July 29, 2020 16:09

Restoring old approach now that tests do not trigger notifications.

94fae7f

Updaing AWS_* env variables.

0521749

weerd merged commit bd96b84 into all-laravel-upgrades Jul 29, 2020

weerd deleted the upgrading-laravel-framework branch July 29, 2020 20:31

weerd mentioned this pull request Aug 3, 2020

All laravel upgrades #1080

Merged

3 tasks

weerd mentioned this pull request Aug 5, 2020

Updating env variables after changes due to Rogue updates. DoSomethingArchive/infrastructure#267

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrading Laravel Framework #1071

Upgrading Laravel Framework #1071

weerd commented Jul 20, 2020 •

edited

Loading

weerd commented Jul 20, 2020 •

edited

Loading

weerd commented Jul 28, 2020

DFurnes Jul 29, 2020

weerd Jul 29, 2020

DFurnes left a comment

DFurnes left a comment

Upgrading Laravel Framework #1071

Upgrading Laravel Framework #1071

Conversation

weerd commented Jul 20, 2020 • edited Loading

What's this PR do?

How should this be reviewed?

Any background context you want to provide?

Relevant tickets

Checklist

weerd commented Jul 20, 2020 • edited Loading

weerd commented Jul 28, 2020

DFurnes Jul 29, 2020

Choose a reason for hiding this comment

weerd Jul 29, 2020

Choose a reason for hiding this comment

DFurnes left a comment

Choose a reason for hiding this comment

DFurnes left a comment

Choose a reason for hiding this comment

weerd commented Jul 20, 2020 •

edited

Loading

weerd commented Jul 20, 2020 •

edited

Loading