Upgrade to Laravel 5.6 #1063
Upgrade to Laravel 5.6 #1063
Conversation
| Request::HEADER_X_FORWARDED_PORT => 'X_FORWARDED_PORT', | ||
| Request::HEADER_X_FORWARDED_PROTO => 'X_FORWARDED_PROTO', | ||
| ]; | ||
| protected $headers = Request::HEADER_X_FORWARDED_ALL; |
There was a problem hiding this comment.
I'm less familiar with Trusted Proxy and want to make sure the new bit property is fine that should encompass the prior series of headers.
| * proxy that connects directly to your server, but also proxies that connect to | ||
| * those proxies, and all the way back until you reach the original source IP. | ||
| */ | ||
| 'proxies' => '*', // [<ip addresses>,], '*', '<ip addresses>,' |
There was a problem hiding this comment.
According to the TrustedProxies Class in the package, the ** value is deprecated in favor of *. I checked and we use an env variable on each Rogue env on Heroku and specify it as **. By defaulting the config to * it should cover the same things and we can remove the env variables from each env on Heroku.
|
Noting here that after the upgrades and running tests I was running into an odd error with tests that use the Instead of the expected series of method calls, after the 5.6 updates, there is a resulting call to the The only thing I could find related in Laravel 5.6 changes was a merged pull request that adds an |
|
Closing in favor of #1071 As it turns out due to some Composer dependencies and the required update to Gateway to fix failing tests in Rogue on Laravel 5.6, we need to push through a few Laravel upgrades in a single PR instead of level by level PR as I had originally planned! I didn't want the branch name to be confusing since it specified only upgrading to 5.6 😉 |
What's this PR do?
This pull request upgrades Rogue from Laravel 5.5 to Laravel 5.6.
How should this be reviewed?
...
Any background context you want to provide?
...
Relevant tickets
References Pivotal #.
Checklist