Upgrading Laravel Framework

.editorconfig

@@ -6,21 +6,15 @@ root = true
 
 
 [*]
-indent_style = space
-indent_size = 2
-
-end_of_line = lf
 charset = utf-8
-trim_trailing_whitespace = true
+end_of_line = lf
 insert_final_newline = true
-
-[*.php]
-indent_style = space
-indent_size = 4
-
-[*.json]
 indent_style = space
 indent_size = 2
+trim_trailing_whitespace = true
 
 [*.md]
 trim_trailing_whitespace = false
+
+[*.php]
+indent_size = 4

.env.example

@@ -1,10 +1,11 @@
 APP_ENV=local
 APP_KEY=
 APP_DEBUG=true
-APP_LOG=daily
-APP_LOG_LEVEL=debug
 APP_URL=http://rogue.test
 
+LOG_CHANNEL=daily
+LOG_SLACK_WEBHOOK_URL=
+
 DB_CONNECTION=mysql
 DB_HOST=127.0.0.1
 DB_PORT=3306
@@ -13,8 +14,8 @@ DB_USERNAME=homestead
 DB_PASSWORD=secret
 
 CACHE_DRIVER=redis
+FILESYSTEM_DRIVER=public
 SESSION_DRIVER=redis
-STORAGE_DRIVER=public
 QUEUE_DRIVER=sync
 
 REDIS_HOST=127.0.0.1

.gitignore

@@ -1,17 +1,15 @@
-/vendor
-/node_modules
-/public/storage
-/storage/debugbar
-Homestead.yaml
-Homestead.json
+.DS_Store
 .env
-.env.dusk.local
+.phpunit.result.cache
 
-.DS_Store
+vendor
+node_modules
+storage/debugbar
+Homestead.yaml
+Homestead.json
 
 public/assets/**
 public/dist
+public/storage
 
 npm-debug.log
-
-/_book

app.json

@@ -77,10 +77,13 @@
     "ASHES_USERNAME": {
       "required": true
     },
-    "ROGUE_API_KEY": {
+    "AWS_S3_BUCKET": {
+      "required": true
+    },
+    "AWS_S3_URL": {
       "required": true
     },
-    "S3_BUCKET": {
+    "ROGUE_API_KEY": {
       "required": true
     },
     "S3_KEY": {
@@ -91,9 +94,6 @@
     },
     "S3_SECRET": {
       "required": true
-    },
-    "S3_URL": {
-      "required": true
     }
   }
 }

app/Exceptions/Handler.php

@@ -28,39 +28,37 @@ class Handler extends ExceptionHandler
     /**
      * Report or log an exception.
      *
-     * This is a great spot to send exceptions to Sentry, Bugsnag, etc.
-     *
-     * @param  \Exception  $e
+     * @param  \Exception  $exceptionxception
      * @return void
      */
-    public function report(Exception $e)
+    public function report(Exception $exception)
     {
-        parent::report($e);
+        parent::report($exception);
     }
 
     /**
      * Render an exception into an HTTP response.
      *
      * @param  \Illuminate\Http\Request  $request
-     * @param  \Exception  $e
-     * @return \Illuminate\Http\Response|\Symfony\Component\HttpFoundation\Response
+     * @param  \Exception  $exception
+     * @return \Illuminate\Http\Response | \Symfony\Component\HttpFoundation\Response
      */
-    public function render($request, Exception $e)
+    public function render($request, Exception $exception)
     {
         // If Intervention can't parse a file (corrupted or wrong type), return 422.
         // @TODO: Handle this with a validation rule on our v3 routes.
-        if ($e instanceof \Intervention\Image\Exception\NotReadableException) {
+        if ($exception instanceof \Intervention\Image\Exception\NotReadableException) {
             abort(422, 'Invalid image provided.');
         }
 
         // Re-cast specific exceptions or uniquely render them:
-        if ($e instanceof GlideNotFoundException) {
-            $e = new NotFoundHttpException('That image could not be found.');
-        } elseif ($e instanceof ModelNotFoundException) {
-            $e = new NotFoundHttpException('That resource could not be found.');
+        if ($exception instanceof GlideNotFoundException) {
+            $exception = new NotFoundHttpException('That image could not be found.');
+        } elseif ($exception instanceof ModelNotFoundException) {
+            $exception = new NotFoundHttpException('That resource could not be found.');
         }
 
-        return parent::render($request, $e);
+        return parent::render($request, $exception);
     }
 
     /**

app/Http/Controllers/PostsController.php

@@ -175,12 +175,14 @@ public function update(PostRequest $request, Post $post)
         // Only allow an admin/staff or the user who owns the post to update.
         $this->authorize('update', $post);
 
+        $validatedRequest = $request->validated();
+
         // But don't allow user's to review their own posts.
         if (! Gate::allows('review', $post)) {
-            unset($request['status']);
+            unset($validatedRequest['status']);
         }
 
-        $this->posts->update($post, $request->validated());
+        $this->posts->update($post, $validatedRequest);
 
         return $this->item($post);
     }

app/Http/Kernel.php

@@ -14,7 +14,7 @@ class Kernel extends HttpKernel
      * @var array
      */
     protected $middleware = [
-        \Illuminate\Foundation\Http\Middleware\CheckForMaintenanceMode::class,
+        \Rogue\Http\Middleware\CheckForMaintenanceMode::class,
         \Illuminate\Foundation\Http\Middleware\ConvertEmptyStringsToNull::class,
         \Illuminate\Foundation\Http\Middleware\ValidatePostSize::class,
         \Rogue\Http\Middleware\TrustProxies::class,
@@ -58,8 +58,10 @@ class Kernel extends HttpKernel
         'guard' => \DoSomething\Gateway\Server\Middleware\SetGuard::class,
         'scopes' => \DoSomething\Gateway\Server\Middleware\RequireScope::class,
         'bindings' => \Illuminate\Routing\Middleware\SubstituteBindings::class,
+        'cache.headers' => \Illuminate\Http\Middleware\SetCacheHeaders::class,
         'can' => \Illuminate\Auth\Middleware\Authorize::class,
         'guest' => \Rogue\Http\Middleware\RedirectIfAuthenticated::class,
+        'signed' => \Illuminate\Routing\Middleware\ValidateSignature::class,
         'role' => \Rogue\Http\Middleware\CheckRole::class,
         'throttle' => \Illuminate\Routing\Middleware\ThrottleRequests::class,
     ];

app/Http/Middleware/CheckForMaintenanceMode.php

@@ -0,0 +1,17 @@
+<?php
+
+namespace Rogue\Http\Middleware;
+
+use Illuminate\Foundation\Http\Middleware\CheckForMaintenanceMode as Middleware;
+
+class CheckForMaintenanceMode extends Middleware
+{
+    /**
+     * The URIs that should be reachable while maintenance mode is enabled.
+     *
+     * @var array
+     */
+    protected $except = [
+        //
+    ];
+}

app/Http/Middleware/TrustProxies.php

@@ -8,23 +8,16 @@
 class TrustProxies extends Middleware
 {
     /**
-     * The trusted proxies for this application,
-     * sourced from 'config/trustedproxy.php'.
+     * The trusted proxies for this application.
      *
      * @var array
      */
     protected $proxies;
 
     /**
-     * The current proxy header mappings.
+     * The headers that should be used to detect proxies.
      *
-     * @var array
+     * @var int
      */
-    protected $headers = [
-        Request::HEADER_FORWARDED => null, // Not set on AWS or Heroku.
-        Request::HEADER_X_FORWARDED_FOR => 'X_FORWARDED_FOR',
-        Request::HEADER_X_FORWARDED_HOST => null, // Not set on AWS or Heroku.
-        Request::HEADER_X_FORWARDED_PORT => 'X_FORWARDED_PORT',
-        Request::HEADER_X_FORWARDED_PROTO => 'X_FORWARDED_PROTO',
-    ];
+    protected $headers = Request::HEADER_X_FORWARDED_ALL;
 }

app/Policies/PostPolicy.php

@@ -2,6 +2,7 @@
 
 namespace Rogue\Policies;
 
+use Rogue\Models\User;
 use Rogue\Models\Post;
 use Illuminate\Auth\Access\HandlesAuthorization;
 
@@ -28,7 +29,7 @@ public function viewAll($user, Post $post)
      * @param  Rogue\Models\Post $post
      * @return bool
      */
-    public function show($user, Post $post)
+    public function show($user = null, Post $post)
     {
         if ($post->status !== 'accepted') {
             return is_staff_user() || is_owner($post);

app/Providers/AppServiceProvider.php

@@ -4,7 +4,6 @@
 
 use Closure;
 use Hashids\Hashids;
-use Rogue\Auth\CustomGate;
 use InvalidArgumentException;
 use Illuminate\Support\Facades\Log;
 use Illuminate\Support\Facades\View;
@@ -24,12 +23,6 @@ class AppServiceProvider extends ServiceProvider
      */
     public function boot()
     {
-        $this->app->singleton(GateContract::class, function ($app) {
-            return new CustomGate($app, function () use ($app) {
-                return call_user_func($app['auth']->userResolver());
-            });
-        });
-
         $this->app->singleton(Hashids::class, function ($app) {
             return new Hashids(config('app.key'), 10);
         });
@@ -56,7 +49,7 @@ public function boot()
         }, 'The :attribute must be a valid ISO-3166-2 region code.');
 
         // Attach the user & request ID to context for all log messages.
-        Log::getMonolog()->pushProcessor(function ($record) {
+        Log::getLogger()->pushProcessor(function ($record) {
             $record['extra']['user_id'] = auth()->id();
             $record['extra']['client_id'] = token()->client();
             $record['extra']['request_id'] = request()->header('X-Request-Id');

artisan

@@ -1,6 +1,8 @@
 #!/usr/bin/env php
 <?php
 
+define('LARAVEL_START', microtime(true));
+
 /*
 |--------------------------------------------------------------------------
 | Register The Auto Loader
@@ -13,7 +15,7 @@
 |
 */
 
-require __DIR__.'/bootstrap/autoload.php';
+require __DIR__.'/vendor/autoload.php';
 
 $app = require_once __DIR__.'/bootstrap/app.php';
 
@@ -40,7 +42,7 @@ $status = $kernel->handle(
 | Shutdown The Application
 |--------------------------------------------------------------------------
 |
-| Once Artisan has finished running. We will fire off the shutdown events
+| Once Artisan has finished running, we will fire off the shutdown events
 | so that any final work may be done by the application before we shut
 | down the process. This is the last thing to happen to the request.
 |