Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor fixes to docs #42

Merged
merged 3 commits into from
Apr 5, 2018
Merged

minor fixes to docs #42

merged 3 commits into from
Apr 5, 2018

Conversation

CleoQc
Copy link
Member

@CleoQc CleoQc commented Apr 5, 2018

Work in progress

@CleoQc CleoQc requested a review from RobertLucian April 5, 2018 18:55
Copy link
Contributor

@RobertLucian RobertLucian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else looks good.

@@ -43,7 +43,7 @@ Instantiating the :ref:`4 sensors<getting-started-chapter>` in Python is a matte
* :py:class:`~di_sensors.light_color_sensor.LightColorSensor`
* :py:class:`~di_sensors.temp_hum_press.TempHumPress`

For these sensors *that start* with the **Easy** word, you can use the same notations as those used and mentioned in the GoPiGo3's :ref:`documentation <gopigo3:hardware-ports-section>`, such as:
If you choose to use a sensor library *that start* with the **Easy** word, you can use the same notations as those used and mentioned in the GoPiGo3's :ref:`documentation <gopigo3:hardware-ports-section>`, such as:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be "that starts".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup

Copy link
Contributor

@RobertLucian RobertLucian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good for merging.

@CleoQc CleoQc merged commit 633fae2 into DexterInd:develop Apr 5, 2018
CleoQc pushed a commit that referenced this pull request Apr 26, 2018
* Add Line Follower drivers and example

* Update dexter_i2c.py

Update dexter_i2c.py to be simpler and more universal by combining
functions.

* Update line_follower.py

Update line_follower.py for recent dexter_i2c.py update

* Feature/easy libraries (#35)

* Move Distance Sensor and Line Follower in here

* remove dependency on mock_package

* remove alias for read_sensors until we know if we need it (probably not)

* Feature/system wide mutex+ easydi_sensors library  (#36)

* Move Distance Sensor and Line Follower in here

* remove dependency on mock_package

* remove alias for read_sensors until we know if we need it (probably not)

* get easydi_sensors from DexterOS

* Check for overall mutex need

* Add systemwide mutex comment

* Add license header and description

* Add license header

* change year in license header

* split easydi_sensors into 3 components for systematic naming convention

* Remove copies of ifMutexAcquire and ifMutexRelease. Keep them in one file

* Be more strict in what we're pulling in from easy_mutex

* poll overall_mutex each time

* remove print statement (#37)

reconfig_bus() is now mutex protected

* feature - update documentation for the latest (#41)

* feature - configuring the environment for RTD

* feature - bulk changes to docs

* feature - add comment on how to build documentation

* feature - add part of the documentation

* feature - completing the documentation for easy sensors + tutorials

* feature - work on the tutorials + other stuff

* feature - fix the mutexes tutorial

* feature - change organization of documentation

* feature - remove an unnecessary section

* feature - show the right command for installing di-sensors

* feature - small changes

* feature - fix documentation & and missing parts

* feature - fix naming of the package

* Revert commit

* minor fixes to docs (#42)

* minor fixes to docs

* minor fixes to doc

* fix grammar

* rename safe_heading to heading_name and re-instate the parameter (#43)

* rename safe_heading to heading_name and re-instate the parameter

* rename from heading_name to convert_heading

* add punctuation

* fix - change name of method in library description section

* Remove references to line follower (#45)
RobertLucian added a commit that referenced this pull request Jun 1, 2018
* Add Line Follower drivers and example

* Update dexter_i2c.py

Update dexter_i2c.py to be simpler and more universal by combining
functions.

* Update line_follower.py

Update line_follower.py for recent dexter_i2c.py update

* Feature/easy libraries (#35)

* Move Distance Sensor and Line Follower in here

* remove dependency on mock_package

* remove alias for read_sensors until we know if we need it (probably not)

* Feature/system wide mutex+ easydi_sensors library  (#36)

* Move Distance Sensor and Line Follower in here

* remove dependency on mock_package

* remove alias for read_sensors until we know if we need it (probably not)

* get easydi_sensors from DexterOS

* Check for overall mutex need

* Add systemwide mutex comment

* Add license header and description

* Add license header

* change year in license header

* split easydi_sensors into 3 components for systematic naming convention

* Remove copies of ifMutexAcquire and ifMutexRelease. Keep them in one file

* Be more strict in what we're pulling in from easy_mutex

* poll overall_mutex each time

* remove print statement (#37)

reconfig_bus() is now mutex protected

* feature - update documentation for the latest (#41)

* feature - configuring the environment for RTD

* feature - bulk changes to docs

* feature - add comment on how to build documentation

* feature - add part of the documentation

* feature - completing the documentation for easy sensors + tutorials

* feature - work on the tutorials + other stuff

* feature - fix the mutexes tutorial

* feature - change organization of documentation

* feature - remove an unnecessary section

* feature - show the right command for installing di-sensors

* feature - small changes

* feature - fix documentation & and missing parts

* feature - fix naming of the package

* Revert commit

* minor fixes to docs (#42)

* minor fixes to docs

* minor fixes to doc

* fix grammar

* rename safe_heading to heading_name and re-instate the parameter (#43)

* rename safe_heading to heading_name and re-instate the parameter

* rename from heading_name to convert_heading

* add punctuation

* fix - change name of method in library description section

* Remove references to line follower (#45)

* feature - add old line follower in (#46)

* feature - adding in the line follower and making basic fixes and adjusts

* feature - fixing paths

* feature - import both versions of the line follower

* feature - change paths accordingly

* feature - fix path issues with di_sensors

* feature - fix path issues

* feature - check if installer runs on GUI-enabled OS

* feature - yet another path issue fixed

* feature - go back to using the same import for the line follower

* feature - import line_sensor correctly in new module

* feature - fix the paths yet again

* feature - add python-periphery as required packafe for line follower

* feature - change how the installation of the sensors goes (#48)

* feature - add installer script for di-sensors

* feature - add install requires for python-periphery

* feature - use the name of the module when identifying the python package

* feature - resize logo to a better aspect ratio

* feature - adjust simple install command

* feature - add readme in installation directory

* feature - modify repo readme

* feature - fix global variable issue

* feature - change how the installation goes

* feature - add the red line follower to the installation

* feature - call configure function for the red line follower

* feature - add/remove feedback instructions in install script

* feature - change version of red line follower to 1.0.0

* fix Line Follower Calibration GUI (#49)

* fix - install sources (#50)

* fix - fix path issue for desktop icon (#51)

* feature - change references for script_tools (#52)

* fix Line Follower Calibration GUI

* Fix path to line_sensor_gui in the desktop file

* feature - change references for script_tools

* use direct links instead of redirects
@CleoQc CleoQc deleted the fix/docs branch March 13, 2019 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants