Visual dashboard for REST API #850
Conversation
# Conflicts: # extensions/exchanges/cexio/products.json
|
This looks very good! Just a little thing: This PR also changes files like neural/strategy.js. Why? |
There was a problem hiding this comment.
For me it's a great YES :
- We should avoid bower implementation as the developpers officialy said stop : Consider deprecating Bower. bower/bower#2298 (going on webpack ?)
- It feels like the whole project is not commented enough, this PR is a plus on this point ^^
- Indentation lovers (like me) will hate you some days 😹
- Is jQuery shouldn't be included through package.json instead of bower ? (just asking)
Love your work =D
There was a problem hiding this comment.
ReferenceError: minimist is not defined, but it is really present:
tradeops@47148:~/zenbot$ npm list minimist
zenbot4@4.0.5 /home/tradeops/zenbot
+-- eslint@4.12.1
| -- mkdirp@0.5.1 | -- minimist@0.0.8
+-- minimist@1.2.0
-- simple-xmpp@1.3.0 -- node-xmpp-client@3.2.0
`-- minimist@1.2.0 deduped
tradeops@47148:~/zenbot$
There was a problem hiding this comment.
@ArnaudRitti can you re-do this PR without the extra changes? I think this is on hold since it changes a ton of other files, including core files such as trade.js, in a way that'll affect others unintentionally.
Would love to see this PR merged, but I don't think it'll happen until those changes are cleaned out and this PR only changes the minimum needed.
|
screenshots look nice.. how do we actually get this running? |
|
This looks awesome, I would love to see this in zenbot. I've wanted to do this for a long time. Any help required to get this over the line? |
…code, as it is depreciated.
…t consumed in api.js also initializes the lib.output later and announces it at the start of live trading
…code, as it is depreciated.
…t consumed in api.js also initializes the lib.output later and announces it at the start of live trading
…t consumed in api.js also initializes the lib.output later and announces it at the start of live trading
…code, as it is depreciated.
…t consumed in api.js also initializes the lib.output later and announces it at the start of live trading
|
So Nice, Great work, when we can use it ? |
* Migrated base code from pull #850 minus dist files and bower code, as it is depreciated. * Add popper.js for bootstrap * add bootstrap, associated packages, and webpack * add more dependencies, remove bootstrap-loader * add babel-preset-es2015 * remove bootstrap css from app.js * integrate non-intrusive changes, convert from bower to webpack, condense all current included css and js * add generation data to gitignore * add webpack dist folder to .gitignore * modify col-xs-* to col-*, per bootstrap 4 * fix typo * code from PR #850, seems to add extra stats to the tradeObject consumed in api.js also initializes the lib.output later and announces it at the start of live trading * Add basic README info * accidental backtick inserted
|
Duplicate of #1015 which was merged into unstable |
Dashboard for zenbot
It work on tablet, desktop and mobile.
On mobile you can add it to home screen and it works like a app.