Skip to content
This repository has been archived by the owner on Feb 15, 2022. It is now read-only.

REST API UI v1.1 #1015

Merged
merged 15 commits into from
Jan 2, 2018
Merged

REST API UI v1.1 #1015

merged 15 commits into from
Jan 2, 2018

Conversation

kernelsndrs
Copy link
Contributor

This is mostly a transfer of code from PR #850, with a refactor from bower to webpack and few small changes related to bootstrap4.

TODO
move to partials, integrate ajax updating
integrate --api flag which sets auto stat dumping and prevents toggle
explore best representation for multiple running zenbot instances

this pull request resubmitted after a failed rebase.

@JensvdHeydt
Copy link
Contributor

@DeviaVir Is anything blocking this PR to be merged?

Copy link
Owner

@DeviaVir DeviaVir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see it in the wild, thanks for contributing! 👍

@DeviaVir DeviaVir merged commit 5e068ff into DeviaVir:unstable Jan 2, 2018
@kernelsndrs kernelsndrs deleted the UI branch January 2, 2018 16:20
@mkuendig
Copy link
Contributor

mkuendig commented Jan 6, 2018

I get this build error related to webpack:

Step #0: > rm -rf node_modules/forex.analytics/.git && webpack -p
Step #0:
Step #0: �[91mNo configuration file found and no output filename configured via CLI option.
Step #0: �[0m�[91mA configuration file could be named 'webpack.config.js' in the current directory.
Step #0: �[0m�[91mUse --help to display the CLI options.
Step #0: �[0m�[91mnpm�[0m�[91m �[0m�[91mERR!�[0m�[91m code ELIFECYCLE

Have tried multiple things to troubleshoot. No luck. When I remove webpack -p from package.json the build completes. Any hints?

Strangely, when I start the container without webpack -p as postinstall and do it after the container is started, npx webpack -p runs successfully.

@DeviaVir
Copy link
Owner

DeviaVir commented Jan 6, 2018

@mkuendig pull latest, this should be fixed now

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants