Skip to content
This repository has been archived by the owner on Feb 15, 2022. It is now read-only.

Remove options key from REST output #809

Closed

Conversation

storm1er
Copy link

@storm1er storm1er commented Dec 6, 2017

Because it contains credentials.

Maybe someone will want to see some options anyway. If you want to see options, Edit this branch as you wish : https://github.com/storm1er/zenbot/tree/remove-options-key-from-REST-output

Because it contains credentials
@abduegal
Copy link
Contributor

@storm1er I just looked at the output of the API and the credentials are not exposed through the options keyword.

"options":{
"paper":true,
"strategy":"sar",
"sell_stop_pct":0,
"buy_stop_pct":0,
"profit_stop_enable_pct":0,
"profit_stop_pct":1,
"max_slippage_pct":5,
"buy_pct":99,
"sell_pct":99,
"order_adjust_time":2500,
"max_sell_loss_pct":25,
"order_poll_time":2500,
"order_type":"maker",
"poll_trades":30000,
"currency_capital":1000,
"asset_capital":0,
"rsi_periods":14,
"avg_slippage_pct":0.045,
"markdown_buy_pct":0,
"markup_sell_pct":0,
"stats":true,
"mode":"paper",
"selector":"gdax.BTC-EUR",
"period":"2m",
"min_periods":52,
"sar_af":0.015,
"sar_max_af":0.3
}

@storm1er
Copy link
Author

How is your config ?
If I understand well, zenbot always read /conf.js then read --conf args ?

I never use this, it's always in /conf/myconf.js, everytime, key included. I don't use /conf.js
My config's files are build this way :

var c = module.exports = {
  "asset_capital": 0,
  "avg_slippage_pct": 0.045,
  "bitfinex": {
    "key": "...",
    "secret": "...",
    "wallet": "exchange"
  },
  "buy_pct": 90,
  "buy_stop_pct": 0,
  "currency_capital": 50,
  "days": 7,
  "down_trend_threshold": 0.05,
  "ema_long_period": 26,
  "ema_short_period": 12,
  "markdown_buy_pct": 0.48,
  "markup_sell_pct": 0.48,
  "max_sell_loss_pct": 25,
  "max_slippage_pct": 5,
  "min_periods": 10,
  "mongo": {
    "host": "localhost",
    "port": 27017,
    "db": "zenbot4",
    "username": null,
    "password": null,
    "replicaSet": null
  },
  "notifiers": {
    "slack": {
      "on": true,
      "webhook_url": "..."
    }
  },
  "order_adjust_time": 5000,
  "order_type": "maker",
  "overbought_rsi": 70,
  "overbought_rsi_periods": 25,
  "period": "5m",
  "profit_stop_enable_pct": 0,
  "profit_stop_pct": 1,
  "rsi_periods": 25,
  "selector": "bitfinex.LTC-USD",
  "sell_pct": 90,
  "sell_stop_pct": 0,
  "show_options": true,
  "signal_period": 9,
  "strategy": "macd",
  "symmetrical": true,
  "up_trend_threshold": 0.05
};

And when I go to the API URL, I can see everything.

@ArnaudRitti
Copy link

Thank you @storm1er, i have already integrated your fix in my PR #850

@storm1er
Copy link
Author

@ArnaudRitti Thanks =D

Duplicate of #850

@storm1er storm1er closed this Dec 13, 2017
@storm1er storm1er deleted the remove-options-key-from-REST-output branch December 13, 2017 19:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants