-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send spans_created
telemetry metric
#2577
Conversation
BenchmarksBenchmark execution time: 2024-03-28 19:40:07 Comparing candidate commit c21845b in PR branch Found 13 performance improvements and 1 performance regressions! Performance is the same for 168 metrics, 0 unstable metrics. scenario:EmptyFileBench/benchEmptyFileOverhead
scenario:EmptyFileBench/benchEmptyFileOverhead-opcache
scenario:HookBench/benchWithoutHook-opcache
scenario:LaravelBench/benchLaravelOverhead
scenario:LaravelBench/benchLaravelOverhead-opcache
scenario:SpanBench/benchDatadogAPI-opcache
scenario:SymfonyBench/benchSymfonyBaseline
scenario:SymfonyBench/benchSymfonyBaseline-opcache
scenario:SymfonyBench/benchSymfonyOverhead
scenario:SymfonyBench/benchSymfonyOverhead-opcache
scenario:WordPressBench/benchEnhancedWordPressOverhead
scenario:WordPressBench/benchEnhancedWordPressOverhead-opcache
scenario:WordPressBench/benchWordPressOverhead
scenario:WordPressBench/benchWordPressOverhead-opcache
|
f391995
to
a2e4165
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2577 +/- ##
============================================
+ Coverage 75.47% 75.52% +0.04%
Complexity 2603 2603
============================================
Files 242 242
Lines 27225 27276 +51
Branches 985 985
============================================
+ Hits 20549 20599 +50
- Misses 6151 6152 +1
Partials 525 525
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
ec441aa
to
996cfe6
Compare
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
…y or OpenTracing Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
5ed1e3c
to
b3de131
Compare
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
df08fc4
to
c21845b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :-)
This reverts commit 7169ff4.
This reverts commit 7169ff4.
Description
spans_created
is the first telemetry metric collected as part of https://datadoghq.atlassian.net/browse/AIT-4125Reviewer checklist