Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Send spans_created telemetry metric" #2612

Closed
wants to merge 1 commit into from

Conversation

realFlowControl
Copy link
Member

Reverts #2577

@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2024

Codecov Report

Merging #2612 (dfa7f9f) into master (633c5ad) will decrease coverage by 12.22%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #2612       +/-   ##
=============================================
- Coverage     76.53%   64.31%   -12.22%     
  Complexity     2609     2609               
=============================================
  Files           217      217               
  Lines         23318    23267       -51     
=============================================
- Hits          17846    14965     -2881     
- Misses         5472     8302     +2830     
Flag Coverage Δ
tracer-extension 78.64% <ø> (-0.07%) ⬇️
tracer-php 46.78% <100.00%> (-27.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
ext/ddtrace.c 73.08% <ø> (-0.19%) ⬇️
ext/ddtrace.h 62.50% <ø> (ø)
ext/ddtrace_arginfo.h 100.00% <ø> (ø)
ext/span.c 92.99% <ø> (-0.02%) ⬇️
ext/span.h 100.00% <ø> (ø)
ext/telemetry.c 100.00% <ø> (+1.17%) ⬆️
src/DDTrace/OpenTelemetry/Span.php 86.03% <ø> (-0.08%) ⬇️
src/DDTrace/OpenTracer/Tracer.php 85.96% <100.00%> (-0.93%) ⬇️
src/DDTrace/OpenTracer1/Tracer.php 85.71% <100.00%> (-0.96%) ⬇️

... and 19 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 633c5ad...dfa7f9f. Read the comment docs.

@pr-commenter
Copy link

pr-commenter bot commented Apr 4, 2024

Benchmarks

Benchmark execution time: 2024-04-04 11:03:04

Comparing candidate commit dfa7f9f in PR branch revert-2577-lv/tracer-telemetry with baseline commit 633c5ad in branch master.

Found 5 performance improvements and 0 performance regressions! Performance is the same for 176 metrics, 1 unstable metrics.

scenario:SpanBench/benchDatadogAPI-opcache

  • 🟩 execution_time [-932.518ns; -628.682ns] or [-5.243%; -3.535%]

scenario:SymfonyBench/benchSymfonyBaseline

  • 🟩 execution_time [-354.504µs; -198.176µs] or [-5.922%; -3.310%]

scenario:SymfonyBench/benchSymfonyBaseline-opcache

  • 🟩 execution_time [-276.250µs; -196.110µs] or [-4.545%; -3.227%]

scenario:SymfonyBench/benchSymfonyOverhead

  • 🟩 execution_time [-798.612µs; -626.088µs] or [-10.168%; -7.971%]

scenario:SymfonyBench/benchSymfonyOverhead-opcache

  • 🟩 execution_time [-688.669µs; -565.251µs] or [-8.697%; -7.139%]

@realFlowControl realFlowControl marked this pull request as ready for review April 4, 2024 12:15
@realFlowControl realFlowControl requested a review from a team as a code owner April 4, 2024 12:15
@realFlowControl realFlowControl deleted the revert-2577-lv/tracer-telemetry branch April 4, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants