Fix a use-after-free

DataDog · Mar 28, 2024 · b3de131 · b3de131
1 parent 55d2c44
commit b3de131
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/ext/span.c b/ext/span.c
@@ -554,13 +554,13 @@ void ddtrace_close_span(ddtrace_span_data *span) {
         ddtrace_switch_span_stack(span->stack);
     }
 
-    ddtrace_close_stack_userland_spans_until(span);
-
-    ddtrace_close_top_span_without_stack_swap(span);
-
     // Telemetry: increment the spans_created counter
     // Must be done at closing because we need to read the "component" span's meta which is not available at creation
     ddtrace_telemetry_inc_spans_created(span);
+
+    ddtrace_close_stack_userland_spans_until(span);
+
+    ddtrace_close_top_span_without_stack_swap(span);
 }
 
 void ddtrace_close_span_restore_stack(ddtrace_span_data *span) {