-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUM-1823: Add buildId to the RUM error and Log events #1756
Merged
0xnm
merged 1 commit into
develop
from
nogorodnikov/rum-1823/attach-build-id-to-rum-error-and-log-events
Apr 5, 2024
Merged
RUM-1823: Add buildId to the RUM error and Log events #1756
0xnm
merged 1 commit into
develop
from
nogorodnikov/rum-1823/attach-build-id-to-rum-error-and-log-events
Apr 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xnm
force-pushed
the
nogorodnikov/rum-1823/attach-build-id-to-rum-error-and-log-events
branch
from
December 8, 2023 10:42
fca53be
to
742d249
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1756 +/- ##
===========================================
- Coverage 83.37% 83.31% -0.06%
===========================================
Files 489 489
Lines 17888 17882 -6
Branches 2665 2659 -6
===========================================
- Hits 14913 14897 -16
- Misses 2245 2252 +7
- Partials 730 733 +3
|
xgouchet
reviewed
Dec 8, 2023
dd-sdk-android-core/src/main/kotlin/com/datadog/android/core/internal/CoreFeature.kt
Outdated
Show resolved
Hide resolved
dd-sdk-android-core/src/test/kotlin/com/datadog/android/core/internal/CoreFeatureTest.kt
Outdated
Show resolved
Hide resolved
jonathanmos
approved these changes
Dec 11, 2023
mariusc83
approved these changes
Dec 12, 2023
0xnm
force-pushed
the
nogorodnikov/rum-1823/attach-build-id-to-rum-error-and-log-events
branch
from
December 13, 2023 13:55
742d249
to
86834e6
Compare
xgouchet
approved these changes
Dec 13, 2023
0xnm
force-pushed
the
nogorodnikov/rum-1823/attach-build-id-to-rum-error-and-log-events
branch
from
April 3, 2024 11:59
86834e6
to
17c7c40
Compare
xgouchet
approved these changes
Apr 3, 2024
0xnm
deleted the
nogorodnikov/rum-1823/attach-build-id-to-rum-error-and-log-events
branch
April 5, 2024 12:31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds
buildId
support for RUM error events and Log events.buildId
will be generated by the Datadog Gradle Plugin (see DataDog/dd-sdk-android-gradle-plugin#211) only for builds which are minified.Once attached to RUM error events and Logs events, it will be used for the symbolication.
NB: although
build_id
is declared in the common schema for RUM events, this PR adds it only for error events.Review checklist (to be filled by reviewers)