Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RUM schema to latest #1853

Closed
wants to merge 1 commit into from
Closed

Conversation

fuzzybinary
Copy link
Member

What does this PR do?

Update RUM schema to latest to add new Error sources.

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Adds new error sources.
@fuzzybinary fuzzybinary requested review from a team as code owners February 13, 2024 15:44
@@ -41,6 +41,11 @@
"description": "The build version for this application",
"readOnly": true
},
"build_id": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's remove this one, this #1756 covers it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll wait and rebase once #1756 goes in. I can work off of this branch to start work on the source override.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we maybe can drop this file for now, we can address this change later when it is needed, with a proper setup of fake data for it.

@fuzzybinary
Copy link
Member Author

Closing in favor of #1855

@fuzzybinary fuzzybinary deleted the jward/schema-update branch February 20, 2024 15:44
@xgouchet xgouchet added this to the Dropped milestone Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants