Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-1822: Inject build ID into mapping file upload and SDK host application as well #211

Merged

Conversation

0xnm
Copy link
Member

@0xnm 0xnm commented Nov 28, 2023

What does this PR do?

This PR brings support of so-called build ID, which will allow us to precisely match stacktrace sent to Datadog with a mapping file.

This is achieved by generating build ID with each build, so that it can be added to the mapping file upload metadata and also stored as a file in the assets folder of the application which is going to be built, so that it can be later read by the SDK in runtime and added to the RUM/Logs errors.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm force-pushed the nogorodnikov/rum-1822/inject-build-id-into-source-map-upload branch from 0ba08f5 to 789aafe Compare November 28, 2023 16:41
@0xnm 0xnm marked this pull request as ready for review November 28, 2023 16:47
@0xnm 0xnm requested a review from a team as a code owner November 28, 2023 16:47
xgouchet
xgouchet previously approved these changes Nov 29, 2023
Copy link
Member

@xgouchet xgouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work !

@0xnm 0xnm force-pushed the nogorodnikov/rum-1822/inject-build-id-into-source-map-upload branch from 789aafe to 6faaf0e Compare November 29, 2023 12:20
@0xnm 0xnm requested a review from xgouchet November 29, 2023 17:43
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2023

Codecov Report

Merging #211 (c4ace3b) into develop (bfff839) will decrease coverage by 6.85%.
The diff coverage is 31.76%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #211      +/-   ##
=============================================
- Coverage      86.05%   79.20%   -6.85%     
- Complexity       181      187       +6     
=============================================
  Files             21       22       +1     
  Lines            588      654      +66     
  Branches          78       81       +3     
=============================================
+ Hits             506      518      +12     
- Misses            55      107      +52     
- Partials          27       29       +2     
Files Coverage Δ
...in/com/datadog/gradle/plugin/DdCheckSdkDepsTask.kt 88.89% <100.00%> (ø)
...m/datadog/gradle/plugin/DdMappingFileUploadTask.kt 89.04% <100.00%> (+0.39%) ⬆️
.../datadog/gradle/plugin/internal/DdAppIdentifier.kt 100.00% <100.00%> (ø)
...m/datadog/gradle/plugin/internal/OkHttpUploader.kt 84.30% <100.00%> (+0.26%) ⬆️
...n/com/datadog/gradle/plugin/GenerateBuildIdTask.kt 0.00% <0.00%> (ø)
...com/datadog/gradle/plugin/DdAndroidGradlePlugin.kt 57.50% <18.00%> (-16.88%) ⬇️

plousada
plousada previously approved these changes Nov 29, 2023
xgouchet
xgouchet previously approved these changes Nov 30, 2023
@0xnm 0xnm force-pushed the nogorodnikov/rum-1822/inject-build-id-into-source-map-upload branch from 9457ea3 to c4ace3b Compare December 8, 2023 12:07
@0xnm 0xnm merged commit 0fd0071 into develop Dec 8, 2023
12 checks passed
@0xnm 0xnm deleted the nogorodnikov/rum-1822/inject-build-id-into-source-map-upload branch December 8, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants