-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUM-1822: Inject build ID into mapping file upload and SDK host application as well #211
Merged
0xnm
merged 3 commits into
develop
from
nogorodnikov/rum-1822/inject-build-id-into-source-map-upload
Dec 8, 2023
Merged
RUM-1822: Inject build ID into mapping file upload and SDK host application as well #211
0xnm
merged 3 commits into
develop
from
nogorodnikov/rum-1822/inject-build-id-into-source-map-upload
Dec 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xnm
force-pushed
the
nogorodnikov/rum-1822/inject-build-id-into-source-map-upload
branch
from
November 28, 2023 16:41
0ba08f5
to
789aafe
Compare
xgouchet
previously approved these changes
Nov 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work !
0xnm
force-pushed
the
nogorodnikov/rum-1822/inject-build-id-into-source-map-upload
branch
from
November 29, 2023 12:20
789aafe
to
6faaf0e
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #211 +/- ##
=============================================
- Coverage 86.05% 79.20% -6.85%
- Complexity 181 187 +6
=============================================
Files 21 22 +1
Lines 588 654 +66
Branches 78 81 +3
=============================================
+ Hits 506 518 +12
- Misses 55 107 +52
- Partials 27 29 +2
|
plousada
previously approved these changes
Nov 29, 2023
xgouchet
previously approved these changes
Nov 30, 2023
This was referenced Dec 4, 2023
0xnm
force-pushed
the
nogorodnikov/rum-1822/inject-build-id-into-source-map-upload
branch
from
December 8, 2023 12:04
2f3d15b
to
9457ea3
Compare
0xnm
force-pushed
the
nogorodnikov/rum-1822/inject-build-id-into-source-map-upload
branch
from
December 8, 2023 12:07
9457ea3
to
c4ace3b
Compare
xgouchet
approved these changes
Dec 8, 2023
0xnm
deleted the
nogorodnikov/rum-1822/inject-build-id-into-source-map-upload
branch
December 8, 2023 12:54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR brings support of so-called build ID, which will allow us to precisely match stacktrace sent to Datadog with a mapping file.
This is achieved by generating build ID with each build, so that it can be added to the mapping file upload metadata and also stored as a file in the
assets
folder of the application which is going to be built, so that it can be later read by the SDK in runtime and added to the RUM/Logs errors.Review checklist (to be filled by reviewers)