-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUM-1915: Add buildId property to the Error event schema #171
RUM-1915: Add buildId property to the Error event schema #171
Conversation
Is it different than |
@BenoitZugmeyer Yes, it is different. It is rather as The point of |
Thanks for the explanation. Maybe it's worth adding a bit more context in the field Is there a reason to nest this field in |
442a5bd
to
8338837
Compare
It is needed only for the symbolication process, to match stacktrace with symbols in the mapping file. And so since I've added a word that it is generated ID in the description. |
I would also lean toward having this attribute at the same level than |
8338837
to
0d895c5
Compare
@bcaudan Thanks for the suggestion, it indeed makes sense keeping in mind the use-case you proposed. I pulled it up to the top level, in the common schema. |
0d895c5
to
0c3ddb2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR adds
error.build_id
property, which will contain unique build ID to be used to match with a mapping file (source map) for more precise symbolication, because different builds may have same version and relying on the version is not enough then.