Production Release #146 #1334
Merged
Production Release #146 #1334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this feature was implemented so that choosing 'No' on supporting_documents led to the old version of Step 2. In fact, 'No' and submit should lead to Step 3, as on Figma.
User is redirected to documents page to upload supporting documents after selecting 'yes'. File is selected and posted to the controller after being selected. This PR does not include upload functionality.
Fix full stops on job search headings
UD1 Redux: Change redirect and update tests, to conform with UX design
…p-up Add page for users to select a file for upload (UD2)
We wanted to provide this data for the business analysts. The columns will be used for upcoming key info features.
We changed the update_school_data.rb to set the new information that we want based on the migration in the earlier commit. This information will be used by the business analysts for school-based metrics. We also want to surface some of this new information to job-seekers to help them make a decision.
…ty-changes-ud2 Add accessibility and content changes to upload document page
…ed-schools-in-scope Better inclusion of new schools in scope
…rom-gias Update schools table
…trics-tables Bigquery calculated time metrics tables
…ools-table-from-gias Revert "Update schools table"
Use GOVUKDesignSystemFormBuilder to upload files
* Refactored the mappings between attributes and imported rows to a hash as this is easier to maintain than assignment lists. Broke these out by complexity. * Moved these to the top of the lib to make the immediately obvious to anyone looking for them. * Alphabetised them to make duplicates more obvious. * Simplified the specs somewhat, although a complete refactor from integration to unit tests would be sensible. * Removed a few expectations from the spec that were already covered in the model spec. TODO: To complete TEVA-28 we still need to export this to BigQuery. Will probably do this in the branch that relates to fixing the BigQuery json schema problem (TEVA-494).
Three days ago the postgres docker containers all got updated. It appears that they now require a password to be set. That broke our pipeline over the weekend. This fixes it. TODO: * Backport this to local docker container build scripts.
This makes `pry` the default REPL in `:development` and `:test` modes. We already use it all the time with `binding.pry` when debugging, so there is no reason not to use it when we're in the console on our local machines.
Serializing the row results in a json array string being stored. What we want is a hash. ActiveRecord handles this automatically when you pass a ruby hash to a json or jsonb attribute. Data from this hash can be accessed like `school.gias_data['URN']`.
Now points to vacancy instead of vacancies Excludes the unused month = null row the previous query was returning
From vacancies to vacancy
The task that export vacancies to big query is broken and we now use a different task for doing that.
…acancies-to-vacancy Switch BigQuery queries from using old vacancies table to vacancy table
…-in-big-query-task Remove export vacancies to bigquery task
…etrics Bigquery flexible working metrics
This was simpler than setting a password. I also changed the postgres and redis containers to use the alpine images as these are much smaller and quicker to pull.
…rebased Upload documents to google drive (UD3, UD6.1, UD6.2)
Update progress spinner icon
cesidio
approved these changes
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this production release