Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch BigQuery queries from using old vacancies table to vacancy table #1324

Merged
merged 5 commits into from
Feb 17, 2020

Conversation

stevenleggdfe
Copy link
Contributor

@stevenleggdfe stevenleggdfe commented Feb 17, 2020

Jira ticket URL:

https://dfedigital.atlassian.net/browse/TEVA-458

Changes in this PR:

The production dataset in BigQuery used to contain a vacancies table which was written to via the BigQuery API. Now we export all tables, including 'vacancy', into Google Cloud Storage as CSVs and then import them into BigQuery that way. This PR moves SQL queries in BigQuery across from using the old vacancies table to using the new vacancy table in BigQuery to allow the code writing to the vacancies table to be removed in future.

@tatyree tatyree force-pushed the bigquery-switch-jobs-from-vacancies-to-vacancy branch from 5006c91 to 8db6d65 Compare February 17, 2020 15:54
@tatyree
Copy link
Contributor

tatyree commented Feb 17, 2020

I've just rebased this against develop and force-pushed the update to get the CI fixes in and the tests passing.

@stevenleggdfe stevenleggdfe merged commit 52a0076 into develop Feb 17, 2020
@stevenleggdfe stevenleggdfe deleted the bigquery-switch-jobs-from-vacancies-to-vacancy branch February 17, 2020 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants