Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add accessibility and content changes to upload document page #1317

Merged
merged 1 commit into from
Feb 13, 2020
Merged

Add accessibility and content changes to upload document page #1317

merged 1 commit into from
Feb 13, 2020

Conversation

Renny4Real
Copy link
Contributor

@Renny4Real Renny4Real commented Feb 13, 2020 •
edited
Loading

This adds some content and accessibility changes that were advised from content and UX review.
Changes:

  • Add aria-described_by tag
  • Change text on the upload button

Screenshot of upload documents page:

Screenshot 2020-02-13 at 10 26 21

dushan-madetech
dushan-madetech approved these changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@dushan-madetech dushan-madetech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approvedaroo 👍

@Renny4Real Renny4Real merged commit 92aa141 into develop Feb 13, 2020
@Renny4Real Renny4Real deleted the add-content-and-accessibility-changes-ud2 branch February 13, 2020 11:47
@dushan-madetech dushan-madetech mentioned this pull request Feb 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-mears-2 david-mears-2 david-mears-2 approved these changes

@dushan-madetech dushan-madetech dushan-madetech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Renny4Real @dushan-madetech @david-mears-2