detect private current_* methods #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some services may declare current_user (or current_* really) as private methods if there is no need to expose that method in the controller. Previously we would miss out on sending the user_id with the event if this was the case, this change allows us to detect these as private methods. For testing purposes, we've made the current_* methods private since that ensures we work with both private and public versions of these methods.
misaka
force-pushed
the
allow-private-current-user
branch
from
bc550ae to
a2b5462
Compare
duncanjbrown
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some services may declare
current_user(orcurrent_*really) as private methods if there is no need to expose that method in the controller. Previously we would miss out on sending theuser_idwith the event if this was the case, this change allows us to detect these as private methods.For testing purposes, we've made the
current_*methods private since that ensures we work with both private and public versions of these methods.