Skip to content

Commit

Permalink
Merge pull request #31 from DFE-Digital/allow-private-current-user
Browse files Browse the repository at this point in the history
detect private current_* methods
  • Loading branch information
Misha Gorodnitzky authored Jul 28, 2022
2 parents 4fc956a + a2b5462 commit 58b0d41
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lib/dfe/analytics/requests.rb
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ def trigger_request_event
.with_response_details(response)
.with_request_uuid(RequestLocals.fetch(:dfe_analytics_request_id) { nil })

request_event.with_user(current_user) if respond_to? :current_user
request_event.with_namespace(current_namespace) if respond_to? :current_namespace
request_event.with_user(current_user) if respond_to?(:current_user, true)
request_event.with_namespace(current_namespace) if respond_to?(:current_namespace, true)

DfE::Analytics::SendEvents.do([request_event.as_json])
end
Expand Down
2 changes: 2 additions & 0 deletions spec/dummy/app/controllers/application_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ def index
render plain: ''
end

private

def current_user
Struct.new(:id).new(1)
end
Expand Down

0 comments on commit 58b0d41

Please sign in to comment.