Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect private current_* methods #31

Merged
merged 1 commit into from
Jul 28, 2022
Merged

detect private current_* methods #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/dfe/analytics/requests.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ def trigger_request_event
.with_response_details(response)
.with_request_uuid(RequestLocals.fetch(:dfe_analytics_request_id) { nil })

request_event.with_user(current_user) if respond_to? :current_user
request_event.with_namespace(current_namespace) if respond_to? :current_namespace
request_event.with_user(current_user) if respond_to?(:current_user, true)
request_event.with_namespace(current_namespace) if respond_to?(:current_namespace, true)

DfE::Analytics::SendEvents.do([request_event.as_json])
end
Expand Down
2 changes: 2 additions & 0 deletions spec/dummy/app/controllers/application_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ def index
render plain: ''
end

private

def current_user
Struct.new(:id).new(1)
end
Expand Down