-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hidden pii updates #143
Merged
Merged
Hidden pii updates #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add hidden_pii.yml * Address PR comments * Update Readme for hidden_pii.yml
* Allow hidden data to be sent separately * Add validation for hidden pii fields appearing on both lists * Update to runtime error, remove logging * Add value to expectation * Ensure allowed_attributes send with updated_at attributes
* Add hidden_pii.yml * Address PR comments * Update Readme for hidden_pii.yml
* Allow hidden data to be sent separately * Add validation for hidden pii fields appearing on both lists * Update to runtime error, remove logging * Add value to expectation * Ensure allowed_attributes send with updated_at attributes
…tions Hidden PII GCP setup instructions
* Cover edge cases for validations * Update to .blank?
* Update log masking method * Fixes for exceptions
* Update custom events to reference hidden_data
asatwal
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Just one minor comment about the update_entity
event type being removed from the README.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to merge hidden_pii_updates into the main branch
Contains 5 PRs