Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hidden pii updates #143

Merged
merged 23 commits into from
Jul 8, 2024
Merged

Hidden pii updates #143

merged 23 commits into from
Jul 8, 2024

Conversation

stevenleggdfe and others added 19 commits May 2, 2024 10:05
* Add hidden_pii.yml
* Address PR comments
* Update Readme for hidden_pii.yml
* Allow hidden data to be sent separately
* Add validation for hidden pii fields appearing on both lists
* Update to runtime error, remove logging
* Add value to expectation
* Ensure allowed_attributes send with updated_at attributes
* Add hidden_pii.yml
* Address PR comments
* Update Readme for hidden_pii.yml
* Allow hidden data to be sent separately
* Add validation for hidden pii fields appearing on both lists
* Update to runtime error, remove logging
* Add value to expectation
* Ensure allowed_attributes send with updated_at attributes
* Cover edge cases for validations

* Update to .blank?
* Update log masking method
* Fixes for exceptions
* Update custom events to reference hidden_data
@ericaporter ericaporter requested a review from asatwal July 2, 2024 14:18
@ericaporter ericaporter self-assigned this Jul 2, 2024
@ericaporter ericaporter marked this pull request as ready for review July 2, 2024 14:31
Copy link
Collaborator

@asatwal asatwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Just one minor comment about the update_entity event type being removed from the README.

README.md Show resolved Hide resolved
@ericaporter ericaporter merged commit 1bfd587 into main Jul 8, 2024
7 checks passed
@ericaporter ericaporter deleted the hidden-pii-updates branch July 8, 2024 15:58
@ericaporter ericaporter mentioned this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants