Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hidden PII GCP setup instructions #138

Merged
merged 8 commits into from
May 10, 2024
Merged

Hidden PII GCP setup instructions #138

merged 8 commits into from
May 10, 2024

Conversation

stevenleggdfe
Copy link
Contributor

@stevenleggdfe stevenleggdfe commented Apr 29, 2024 •
edited
Loading

Adds additional steps to the GCP setup instructions required for hidden PII:

  • Creation of the hidden_DATA PII field in the events table
  • Additional permissions in custom roles
  • Extra steps to set up the policy tag / taxonomy and apply it to the hidden_DATA field to ensure it is actually hidden in BQ

@stevenleggdfe stevenleggdfe force-pushed the hidden-pii-gcp-setup-instructions branch from bad90e5 to 60e29d9 Compare May 2, 2024 09:05
@stevenleggdfe stevenleggdfe changed the base branch from main to hidden-pii-updates May 2, 2024 09:08
@ericaporter ericaporter force-pushed the hidden-pii-updates branch from a9646d3 to 7cb4942 Compare May 2, 2024 09:18
@stevenleggdfe stevenleggdfe requested a review from asatwal May 2, 2024 09:20
asatwal
asatwal reviewed May 3, 2024
View reviewed changes
Copy link
Collaborator

@asatwal asatwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevenleggdfe - the field data_hidden needs to be renamed to hidden_data. Otherwise looks good.

docs/create-events-table.sql Outdated Show resolved Hide resolved
docs/google_cloud_bigquery_setup.md Outdated Show resolved Hide resolved
@ericaporter ericaporter force-pushed the hidden-pii-updates branch from 4cc03b5 to f5114a2 Compare May 8, 2024 10:23
@stevenleggdfe stevenleggdfe requested a review from asatwal May 9, 2024 14:45
asatwal
asatwal approved these changes May 10, 2024
View reviewed changes
Copy link
Collaborator

@asatwal asatwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@stevenleggdfe stevenleggdfe merged commit 1eefb72 into hidden-pii-updates May 10, 2024
@stevenleggdfe stevenleggdfe deleted the hidden-pii-gcp-setup-instructions branch May 10, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asatwal asatwal asatwal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevenleggdfe @asatwal